#67 remove imports and added delete activity failed

Author: daros10

src/app/modules/activities-management/store/activity-management.actions.ts

@@ -11,6 +11,7 @@ export enum ActivityManagementActionTypes {
   CREATE_ACTIVITY_FAIL = '[ActivityManagement] CREATE_ACTIVITY_FAIL',
   DELETE_ACTIVITY = '[ActivityManagement] Delete Activity',
   DELETE_ACTIVITY_SUCCESS = '[ActivityManagement] Delete Activity Success',
+  DELETE_ACTIVITY_FAIL = '[ActivityManagement] Delete Activity Fail',
 }
 
 export class LoadActivities implements Action {
@@ -59,6 +60,12 @@ export class DeleteActivitySuccess implements Action {
   constructor(public activityId: string) {}
 }
 
+export class DeleteActivityFail implements Action {
+  public readonly type = ActivityManagementActionTypes.DELETE_ACTIVITY_FAIL;
+
+  constructor(public error: string) {}
+}
+
 export type ActivityManagementActions =
   | LoadActivities
   | LoadActivitiesSuccess
@@ -67,4 +74,5 @@ export type ActivityManagementActions =
   | CreateActivitySuccess
   | CreateActivityFail
   | DeleteActivity
-  | DeleteActivitySuccess;
+  | DeleteActivitySuccess
+  | DeleteActivityFail;

src/app/modules/activities-management/store/activity-management.effects.ts

@@ -7,7 +7,6 @@ import { catchError, map, mergeMap } from 'rxjs/operators';
 import * as actions from './activity-management.actions';
 import { Activity } from './../../shared/models/activity.model';
 import { ActivityService } from './../services/activity.service';
-import { ActivityManagementActionTypes, DeleteActivitySuccess } from './activity-management.actions';
 
 @Injectable()
 export class ActivityEffects {
@@ -42,13 +41,14 @@ export class ActivityEffects {
 
   @Effect()
   deleteActivity$: Observable<Action> = this.actions$.pipe(
-    ofType(ActivityManagementActionTypes.DELETE_ACTIVITY),
+    ofType(actions.ActivityManagementActionTypes.DELETE_ACTIVITY),
     map((action: actions.DeleteActivity) => action.activityId),
     mergeMap((activityId) =>
       this.activityService.deleteActivity(activityId).pipe(
         map(() => {
-          return new DeleteActivitySuccess(activityId);
-        })
+          return new actions.DeleteActivitySuccess(activityId);
+        }),
+        catchError((error) => of(new actions.DeleteActivityFail(error)))
       )
     )
   );

src/app/modules/activities-management/store/activity-management.reducers.ts

@@ -59,6 +59,7 @@ export function activityManagementReducer(state: ActivityState = initialState, a
     case ActivityManagementActionTypes.DELETE_ACTIVITY: {
       return {
         ...state,
+        isLoading: true,
         message: 'Activity removed successfully!',
       };
     }
@@ -71,6 +72,14 @@ export function activityManagementReducer(state: ActivityState = initialState, a
         message: 'Activity removed successfully!',
       };
     }
+
+    case ActivityManagementActionTypes.DELETE_ACTIVITY_FAIL: {
+      return {
+        data: [],
+        isLoading: false,
+        message: 'Something went wrong creating activities!',
+      };
+    }
     default:
       return state;
   }