Skip to content

Remove Technology as domain entity. #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 23, 2020
Merged

Remove Technology as domain entity. #39

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d1cf085
Fixes #37 - remove technology resource
Angeluz-07 Mar 23, 2020
825caf9
Fixes #37 - add pyodbc to requirements
Angeluz-07 Mar 23, 2020
379074b
Fixes #37 - make field technologies as list of strings
Angeluz-07 Mar 23, 2020
49f4e66
Fixes #37 - make technologies' names all lowercase
Angeluz-07 Mar 23, 2020
53b324d
Fixes #37 - udpate description of technologies
Angeluz-07 Mar 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes #37 - make field technologies as list of strings
  • Loading branch information
@Angeluz-07
Angeluz-07 committed Mar 23, 2020
commit 379074bd089eefd671e44ad9f1de65b710138a8b
17 changes: 12 additions & 5 deletions time_tracker_api/time_entries/time_entries_namespace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,18 @@
description='The id of the selected activity',
example=faker.random_int(1, 9999),
),
'technologies': fields.String(
required=True,
title='Technologies',
max_length=64,
description='Canonical names of the used technologies during this period',
'technologies': fields.List(
fields.String(
required=True,
title='Technologies',
max_length=64,
description='Canonical names of the used technologies during this period',
Copy link
Contributor

@enriquezrene enriquezrene Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this description more clear for you?

Technology names used in this time-entry

),
example=faker.words(
3,
['Java', 'Elixir', 'Python', 'Docker'],
Copy link
Contributor

@EliuX EliuX Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that as canonical names they should be in lowercase, as commented by @enriquezrene in this ticket.

unique=True
)
),
'description': fields.String(
title='Comments',
Expand Down