fix: TT-404 flake8

Author: scastillo-jp

V2/tests/api/azure/time_entry_azure_endpoints_test.py

@@ -19,6 +19,7 @@ def _new_time_entry(time_entry: _domain.TimeEntry, database: DB):
         return new_time_entry.__dict__
     return _new_time_entry
 
+
 def test__time_entry_azure_endpoint__creates_an_time_entry__when_time_entry_has_all_attributes(
     test_db, time_entry_factory, activity_factory, insert_activity
 ):
@@ -39,10 +40,11 @@ def test__time_entry_azure_endpoint__creates_an_time_entry__when_time_entry_has_
     assert response.status_code == 201
     assert time_entry_json_data == time_entry_body
 
+
 def test__time_entry_azure_endpoint__returns_all_time_entries(
-     create_fake_database, time_entry_factory, insert_time_entry, activity_factory, insert_activity
+    _test_db, time_entry_factory, insert_time_entry, activity_factory, insert_activity
 ):
-    fake_database = create_fake_database
+    fake_database = _test_db
     inserted_activity = insert_activity(activity_factory(), fake_database)
     existent_time_entries = time_entry_factory(activity_id=inserted_activity.id, technologies="[jira,sql]")
     inserted_time_entries = [insert_time_entry(existent_time_entries, fake_database)]
@@ -58,9 +60,9 @@ def test__time_entry_azure_endpoint__returns_all_time_entries(
 
 
 def test__time_entry_azure_endpoint__returns_an_time_entry__when_time_entry_matches_its_id(
-     create_fake_database, time_entry_factory, insert_time_entry, activity_factory, insert_activity
+     _test_db, time_entry_factory, insert_time_entry, activity_factory, insert_activity
 ):
-    fake_database = create_fake_database
+    fake_database = _test_db
     inserted_activity = insert_activity(activity_factory(), fake_database)
     existent_time_entries = time_entry_factory(activity_id=inserted_activity.id, technologies="[jira,sql]")
     inserted_time_entries = insert_time_entry(existent_time_entries, fake_database)
@@ -82,9 +84,9 @@ def test__time_entry_azure_endpoint__returns_an_time_entry__when_time_entry_matc
 
 
 def test__get_time_entries_azure_endpoint__returns_a_status_code_400__when_time_entry_recive_invalid_id(
-    create_fake_database, time_entry_factory, insert_time_entry, activity_factory, insert_activity
+    _test_db, time_entry_factory, insert_time_entry, activity_factory, insert_activity
 ):
-    fake_database = create_fake_database
+    fake_database = _test_db
     inserted_activity = insert_activity(activity_factory(), fake_database)
     existent_time_entries = time_entry_factory(activity_id=inserted_activity.id, technologies="[jira,sql]")
     insert_time_entry(existent_time_entries, fake_database)

V2/tests/conftest.py

@@ -1,2 +1,2 @@
 # flake8: noqa
-from fixtures import _activity_factory, _test_db, _create_fake_database, _create_fake_dao, _time_entry_factory,_insert_activity
+from fixtures import _activity_factory, _test_db, _create_fake_dao, _time_entry_factory,_insert_activity

V2/tests/fixtures.py

@@ -29,19 +29,14 @@ def _test_db() -> DB:
     db_fake.get_session().execute("pragma foreign_keys=ON")
     return db_fake
 
+
 @pytest.fixture(name='create_fake_dao')
 def _create_fake_dao() -> domain_activities.ActivitiesDao:
     db_fake = DB('sqlite:///:memory:')
     dao = infrastructure_activities.ActivitiesSQLDao(db_fake)
     return dao
 
 
-@pytest.fixture(name='create_fake_database')
-def _create_fake_database() -> DB:
-    db_fake = DB('sqlite:///:memory:')
-    return db_fake
-
-
 @pytest.fixture(name='time_entry_factory')
 def _time_entry_factory() -> domain_time_entries.TimeEntry:
     def _make_time_entry(

V2/time_tracker/time_entries/_domain/_services/_time_entry.py

@@ -6,7 +6,7 @@
 class TimeEntryService:
     def __init__(self, time_entry_dao: TimeEntriesDao):
         self.time_entry_dao = time_entry_dao
-    
+
     def create(self, time_entry_data: TimeEntry) -> TimeEntry:
         return self.time_entry_dao.create(time_entry_data)