Skip to content

Commit fa38bbc

Browse files
committed
refactor: TT-404 apply flake8
1 parent 47edb1a commit fa38bbc

File tree

18 files changed

+77
-62
lines changed

18 files changed

+77
-62
lines changed

V2/tests/conftest.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,4 @@
11
# flake8: noqa
2-
from fixtures import _activity_factory, _create_fake_dao, _create_fake_database
2+
from fixtures import _activity_factory, _create_fake_dao, _create_fake_database
3+
from tests.api.api_fixtures import create_temp_activities
4+
from tests.api.api_fixtures import create_temp_time_entries
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
1+
# flake8: noqa
12
from ._time_entries import create_time_entry
2-
from ._time_entries import get_time_entries
3+
from ._time_entries import get_time_entries
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
1+
# flake8: noqa
12
from ._create_time_entry import create_time_entry
23
from ._get_time_entries import get_time_entries
Lines changed: 33 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
import dataclasses
21
import json
3-
import typing
42

53
import azure.functions as func
64

@@ -11,39 +9,40 @@
119
'time_entries/_infrastructure/_data_persistence/time_entries_data.json'
1210
)
1311

12+
1413
def create_time_entry(req: func.HttpRequest) -> func.HttpResponse:
1514

16-
time_entry_dao = _infrastructure.TimeEntriesJsonDao(_JSON_PATH)
17-
time_entry_service = _domain.TimeEntryService(time_entry_dao)
18-
use_case = _domain._use_cases.CreateTimeEntryUseCase(time_entry_service)
19-
20-
time_entry_data = req.get_json()
21-
22-
time_entry_to_create = _domain.TimeEntry(
23-
id=None,
24-
start_date=time_entry_data["start_date"],
25-
owner_id=time_entry_data["owner_id"],
26-
description=time_entry_data["description"],
27-
activity_id=time_entry_data["activity_id"],
28-
uri=time_entry_data["uri"],
29-
technologies=time_entry_data["technologies"],
30-
end_date=time_entry_data["end_date"],
31-
deleted=time_entry_data["deleted"],
32-
timezone_offset=time_entry_data["timezone_offset"],
33-
project_id=time_entry_data["project_id"]
34-
)
35-
36-
created_time_entry = use_case.create_time_entry(time_entry_to_create.__dict__)
37-
38-
if not created_time_entry:
39-
return func.HttpResponse(
40-
body=json.dumps({'error': 'time_entry could not be created'}),
41-
status_code=500,
42-
mimetype="application/json"
15+
time_entry_dao = _infrastructure.TimeEntriesJsonDao(_JSON_PATH)
16+
time_entry_service = _domain.TimeEntryService(time_entry_dao)
17+
use_case = _domain._use_cases.CreateTimeEntryUseCase(time_entry_service)
18+
19+
time_entry_data = req.get_json()
20+
21+
time_entry_to_create = _domain.TimeEntry(
22+
id=None,
23+
start_date=time_entry_data["start_date"],
24+
owner_id=time_entry_data["owner_id"],
25+
description=time_entry_data["description"],
26+
activity_id=time_entry_data["activity_id"],
27+
uri=time_entry_data["uri"],
28+
technologies=time_entry_data["technologies"],
29+
end_date=time_entry_data["end_date"],
30+
deleted=time_entry_data["deleted"],
31+
timezone_offset=time_entry_data["timezone_offset"],
32+
project_id=time_entry_data["project_id"]
4333
)
4434

45-
return func.HttpResponse(
46-
body=json.dumps(created_time_entry.__dict__),
47-
status_code=201,
48-
mimetype="application/json"
49-
)
35+
created_time_entry = use_case.create_time_entry(time_entry_to_create.__dict__)
36+
37+
if not created_time_entry:
38+
return func.HttpResponse(
39+
body=json.dumps({'error': 'time_entry could not be created'}),
40+
status_code=500,
41+
mimetype="application/json"
42+
)
43+
44+
return func.HttpResponse(
45+
body=json.dumps(created_time_entry.__dict__),
46+
status_code=201,
47+
mimetype="application/json"
48+
)

V2/time_tracker/time_entries/_application/_time_entries/_get_time_entries.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
'time_tracker/time_entries/_infrastructure/_data_persistence/time_entries_data.json'
99
)
1010

11+
1112
def get_time_entries(req: func.HttpRequest) -> func.HttpResponse:
1213

1314
time_entry_id = req.route_params.get('id')

V2/time_tracker/time_entries/_domain/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# flake8: noqa
12
from ._entities import TimeEntry
23
from ._persistence_contracts import TimeEntriesDao
34
from ._services import TimeEntryService
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1-
from ._time_entry import TimeEntry
1+
# flake8: noqa
2+
from ._time_entry import TimeEntry

V2/time_tracker/time_entries/_domain/_entities/_time_entry.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
from dataclasses import dataclass
22
from typing import List
33

4+
45
@dataclass(frozen=True)
56
class TimeEntry:
67
id: int
@@ -13,4 +14,4 @@ class TimeEntry:
1314
end_date: str
1415
deleted: str
1516
timezone_offset: str
16-
project_id: int
17+
project_id: int
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1-
from ._time_entries_dao import TimeEntriesDao
1+
# flake8: noqa
2+
from ._time_entries_dao import TimeEntriesDao

V2/time_tracker/time_entries/_domain/_persistence_contracts/_time_entries_dao.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,16 @@
33

44
from time_tracker.time_entries._domain import TimeEntry
55

6+
67
class TimeEntriesDao(abc.ABC):
78
@abc.abstractmethod
89
def get_by_id(self, id: str) -> TimeEntry:
9-
pass
10+
pass
1011

1112
@abc.abstractmethod
1213
def get_all(self) -> typing.List[TimeEntry]:
1314
pass
1415

1516
@abc.abstractmethod
1617
def create(self, time_entry_data: dict) -> TimeEntry:
17-
pass
18+
pass

0 commit comments

Comments
 (0)