refactor: TT-430 add parse status number to string value

Author: Jobzi

V2/tests/api/azure/activity_azure_endpoints_test.py

@@ -4,6 +4,8 @@
 import azure.functions as func
 
 import time_tracker.activities._application._activities as azure_activities
+from time_tracker.activities._application._activities.utils import parse_status_to_string_for_ui as parse_status
+from time_tracker.utils.enums import StatusEnums
 
 ACTIVITY_URL = '/api/activities/'
 
@@ -13,8 +15,8 @@ def test__activity_azure_endpoint__returns_all_activities(
 ):
     existent_activities = [activity_factory(), activity_factory()]
     inserted_activities = [
-        insert_activity(existent_activities[0], test_db).__dict__,
-        insert_activity(existent_activities[1], test_db).__dict__
+        parse_status(insert_activity(existent_activities[0], test_db).__dict__),
+        parse_status(insert_activity(existent_activities[1], test_db).__dict__)
     ]
 
     req = func.HttpRequest(method='GET', body=None, url=ACTIVITY_URL)
@@ -29,7 +31,7 @@ def test__activity_azure_endpoint__returns_an_activity__when_activity_matches_it
     test_db, activity_factory, insert_activity
 ):
     existent_activity = activity_factory()
-    inserted_activity = insert_activity(existent_activity, test_db).__dict__
+    inserted_activity = parse_status(insert_activity(existent_activity, test_db).__dict__)
 
     req = func.HttpRequest(
         method='GET',
@@ -62,15 +64,15 @@ def test__activity_azure_endpoint__returns_an_activity_with_inactive_status__whe
     activity_json_data = json.loads(response.get_body().decode("utf-8"))
 
     assert response.status_code == 200
-    assert activity_json_data['status'] == 0
+    assert activity_json_data['status'] == StatusEnums(0).name
     assert activity_json_data['deleted'] is True
 
 
 def test__update_activity_azure_endpoint__returns_an_activity__when_found_an_activity_to_update(
     test_db, activity_factory, insert_activity
 ):
     existent_activity = activity_factory()
-    inserted_activity = insert_activity(existent_activity, test_db).__dict__
+    inserted_activity = parse_status(insert_activity(existent_activity, test_db).__dict__)
 
     activity_body = {"description": Faker().sentence()}
     req = func.HttpRequest(
@@ -108,4 +110,4 @@ def test__activity_azure_endpoint__creates_an_activity__when_activity_has_all_at
     activity_body['id'] = activitiy_json_data['id']
 
     assert response.status_code == 201
-    assert activitiy_json_data == activity_body
+    assert activitiy_json_data == parse_status(activity_body)

V2/time_tracker/activities/_application/_activities/_create_activity.py

@@ -7,6 +7,7 @@
 from ... import _domain
 from ... import _infrastructure
 from time_tracker._infrastructure import DB
+from .utils import parse_status_to_string_for_ui as parse_status
 
 
 def create_activity(req: func.HttpRequest) -> func.HttpResponse:
@@ -27,8 +28,8 @@ def create_activity(req: func.HttpRequest) -> func.HttpResponse:
         id=None,
         name=activity_data['name'],
         description=activity_data['description'],
-        status=activity_data['status'],
-        deleted=activity_data['deleted']
+        status=None,
+        deleted=None
     )
 
     created_activity = use_case.create_activity(activity_to_create)
@@ -39,15 +40,16 @@ def create_activity(req: func.HttpRequest) -> func.HttpResponse:
             mimetype="application/json",
         )
     return func.HttpResponse(
-        body=json.dumps(created_activity.__dict__),
+        body=json.dumps(parse_status(created_activity.__dict__)),
         status_code=201,
         mimetype="application/json"
     )
 
 
 def _validate_activity(activity_data: dict) -> typing.List[str]:
-    activity_fields = [field.name for field in dataclasses.fields(_domain.Activity)]
-    missing_keys = [field for field in activity_fields if field not in activity_data]
+    activity_fields = [field for field in dataclasses.fields(_domain.Activity)]
+    missing_keys = [field.name for field in activity_fields
+                    if (field.name not in activity_data) and (field.type != typing.Optional[field.type])]
     return [
         f'The {missing_key} key is missing in the input data'
         for missing_key in missing_keys

V2/time_tracker/activities/_application/_activities/_delete_activity.py

@@ -3,9 +3,11 @@
 
 import azure.functions as func
 
+
 from ... import _domain
 from ... import _infrastructure
 from time_tracker._infrastructure import DB
+from .utils import parse_status_to_string_for_ui as parse_status
 
 
 def delete_activity(req: func.HttpRequest) -> func.HttpResponse:
@@ -32,7 +34,7 @@ def _delete(activity_id: int) -> str:
         _create_activity_service(database)
     )
     activity = activity_use_case.delete_activity(activity_id)
-    return json.dumps(activity.__dict__) if activity else b'Not found'
+    return json.dumps(parse_status(activity.__dict__)) if activity else b'Not found'
 
 
 def _create_activity_service(db: DB) -> _domain.ActivityService:

V2/time_tracker/activities/_application/_activities/_get_activities.py

@@ -6,6 +6,7 @@
 from ... import _domain
 from ... import _infrastructure
 from time_tracker._infrastructure import DB
+from .utils import parse_status_to_string_for_ui as parse_status
 
 
 def get_activities(req: func.HttpRequest) -> func.HttpResponse:
@@ -39,7 +40,7 @@ def _get_by_id(activity_id: int, database: DB) -> str:
     )
     activity = activity_use_case.get_activity_by_id(activity_id)
 
-    return json.dumps(activity.__dict__) if activity else b'Not Found'
+    return json.dumps(parse_status(activity.__dict__)) if activity else b'Not Found'
 
 
 def _get_all(database: DB) -> str:
@@ -48,7 +49,7 @@ def _get_all(database: DB) -> str:
     )
     return json.dumps(
         [
-            activity.__dict__
+            parse_status(activity.__dict__)
             for activity in activities_use_case.get_activities()
         ]
     )

V2/time_tracker/activities/_application/_activities/_update_activity.py

@@ -7,6 +7,7 @@
 from ... import _domain
 from ... import _infrastructure
 from time_tracker._infrastructure import DB
+from .utils import parse_status_to_string_for_ui as parse_status
 
 
 def update_activity(req: func.HttpRequest) -> func.HttpResponse:
@@ -45,7 +46,7 @@ def _update(activity_id: int, activity_data: dict) -> str:
         activity_data.get("status"),
         activity_data.get("deleted")
         )
-    return json.dumps(activity.__dict__) if activity else b'Not Found'
+    return json.dumps(parse_status(activity.__dict__)) if activity else b'Not Found'
 
 
 def _create_activity_service(db: DB) -> _domain.ActivityService:

V2/time_tracker/activities/_application/_activities/utils.py

@@ -0,0 +1,6 @@
+from time_tracker.utils.enums import StatusEnums
+
+
+def parse_status_to_string_for_ui(activity: dict) -> dict:
+    activity['status'] = StatusEnums(activity['status']).name
+    return activity

V2/time_tracker/activities/_domain/_entities/_activity.py

@@ -1,10 +1,12 @@
+import typing
+
 from dataclasses import dataclass
 
 
 @dataclass(frozen=True)
 class Activity:
-    id: int
+    id: typing.Optional[int]
     name: str
     description: str
-    deleted: bool
-    status: int
+    deleted: typing.Optional[bool]
+    status: typing.Optional[int]

V2/time_tracker/utils/enums/__init__.py

@@ -1,2 +1,3 @@
 # flake8: noqa
-from .response_enums import ResponseEnums
+from .response_enums import ResponseEnums
+from .status_enums import StatusEnums

V2/time_tracker/utils/enums/status_enums.py

@@ -0,0 +1,6 @@
+from enum import Enum
+
+
+class StatusEnums(Enum):
+    inactive = 0
+    active = 1