refactor: TT-185 rename get_string_without_empty_spaces to remove_white_spaces

Author: kellycastrof

tests/time_tracker_api/time_entries/time_entries_query_builder_test.py

@@ -4,7 +4,7 @@
 from time_tracker_api.time_entries.time_entries_query_builder import (
     TimeEntryQueryBuilder,
 )
-from utils.repository import get_string_without_empty_spaces
+from utils.repository import remove_white_spaces
 
 
 def test_TimeEntryQueryBuilder_is_subclass_CosmosDBQueryBuilder():
@@ -73,9 +73,7 @@ def test_build_with_add_sql_date_range_condition():
                     """
     query = time_entry_query_builder.get_query()
 
-    assert get_string_without_empty_spaces(
-        query
-    ) == get_string_without_empty_spaces(expected_query)
+    assert remove_white_spaces(query) == remove_white_spaces(expected_query)
 
     assert len(time_entry_query_builder.where_conditions) == 1
     assert len(time_entry_query_builder.get_parameters()) == 2

tests/utils/query_builder_test.py

@@ -1,6 +1,6 @@
 from unittest.mock import patch
 from utils.query_builder import CosmosDBQueryBuilder
-from utils.repository import get_string_without_empty_spaces
+from utils.repository import remove_white_spaces
 import pytest
 
 
@@ -234,9 +234,7 @@ def test_build_with_all_calls_return_query_with_all_conditions():
                     LIMIT @limit
                     """
 
-    assert get_string_without_empty_spaces(
-        query
-    ) == get_string_without_empty_spaces(expected_query)
+    assert remove_white_spaces(query) == remove_white_spaces(expected_query)
 
     assert len(query_builder.get_parameters()) > 0
     assert len(query_builder.where_conditions) > 0
@@ -258,8 +256,8 @@ def test_build_with_empty_and_None_attributes_return_query_select_all():
     query = query_builder.get_query()
 
     expected_query = """SELECT * FROM c"""
-    query = get_string_without_empty_spaces(query)
-    expected_query = get_string_without_empty_spaces(expected_query)
+    query = remove_white_spaces(query)
+    expected_query = remove_white_spaces(expected_query)
 
     assert query == expected_query
     assert len(query_builder.get_parameters()) == 0

tests/utils/repository_test.py

@@ -1,6 +1,9 @@
 from unittest.mock import patch
-from utils.repository import convert_list_to_tuple_string, create_sql_in_condition
-from utils.repository import get_string_without_empty_spaces
+from utils.repository import (
+    convert_list_to_tuple_string,
+    create_sql_in_condition,
+    remove_white_spaces,
+)
 import pytest
 
 
@@ -42,12 +45,18 @@ def test_convert_list_to_tuple_string_should_success(
     [
         ("customer_id", ["id1"], "c.customer_id IN ('id1')"),
         ("customer_id", ["id1", "id2"], "c.customer_id IN ('id1', 'id2')"),
-        ("customer_id", ["id1", "id2", "id3", "id4"],
-         "c.customer_id IN ('id1', 'id2', 'id3', 'id4')"),
+        (
+            "customer_id",
+            ["id1", "id2", "id3", "id4"],
+            "c.customer_id IN ('id1', 'id2', 'id3', 'id4')",
+        ),
         ("id", ["id1"], "c.id IN ('id1')"),
         ("id", ["id1", "id4"], "c.id IN ('id1', 'id4')"),
-        ("id", ["id1", "id2", "id3", "id4"],
-         "c.id IN ('id1', 'id2', 'id3', 'id4')"),
+        (
+            "id",
+            ["id1", "id2", "id3", "id4"],
+            "c.id IN ('id1', 'id2', 'id3', 'id4')",
+        ),
     ],
 )
 def test_create_sql_in_condition(
@@ -67,6 +76,6 @@ def test_create_sql_in_condition(
         (""" SELECT * from c             """, "SELECT * from c"),
     ],
 )
-def test_get_string_without_empty_spaces(string, expected_string):
-    string = get_string_without_empty_spaces(string)
+def test_remove_white_spaces(string, expected_string):
+    string = remove_white_spaces(string)
     assert string == expected_string

utils/repository.py

@@ -15,7 +15,7 @@ def create_sql_in_condition(field, values):
     return "c.{field} IN {list}".format(field=field, list=tuple_string)
 
 
-def get_string_without_empty_spaces(string: str):
+def remove_white_spaces(string: str):
     from re import sub
 
     string = string.replace("\n", "")