Skip to content

Commit b993c85

Browse files
authored
Merge pull request #115 from ioet/114-description-not-required
fix: #114 description should be optional
2 parents 24f2fcf + d31cfc9 commit b993c85

File tree

5 files changed

+11
-9
lines changed

5 files changed

+11
-9
lines changed

time_tracker_api/activities/activities_namespace.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from flask_restplus._http import HTTPStatus
44

55
from time_tracker_api.activities.activities_model import create_dao
6-
from time_tracker_api.api import common_fields, api, remove_required_constraint
6+
from time_tracker_api.api import common_fields, api, remove_required_constraint, NullableString
77

88
faker = Faker()
99

@@ -18,7 +18,7 @@
1818
description='Canonical name of the activity',
1919
example=faker.word(['Development', 'Training']),
2020
),
21-
'description': fields.String(
21+
'description': NullableString(
2222
title='Description',
2323
required=False,
2424
description='Comments about the activity',

time_tracker_api/customers/customers_namespace.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from flask_restplus import Resource, fields
33
from flask_restplus._http import HTTPStatus
44

5-
from time_tracker_api.api import common_fields, api, remove_required_constraint
5+
from time_tracker_api.api import common_fields, api, remove_required_constraint, NullableString
66
from time_tracker_api.customers.customers_model import create_dao
77

88
faker = Faker()
@@ -18,7 +18,7 @@
1818
description='Name of the customer',
1919
example=faker.company(),
2020
),
21-
'description': fields.String(
21+
'description': NullableString(
2222
title='Description',
2323
required=False,
2424
max_length=250,

time_tracker_api/project_types/project_types_namespace.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
from flask_restplus import Resource, fields
33
from flask_restplus._http import HTTPStatus
44

5-
from time_tracker_api.api import common_fields, create_attributes_filter, api, UUID, remove_required_constraint
5+
from time_tracker_api.api import common_fields, create_attributes_filter, api, UUID, remove_required_constraint, \
6+
NullableString
67
from time_tracker_api.project_types.project_types_model import create_dao
78

89
faker = Faker()
@@ -18,7 +19,7 @@
1819
description='Name of the project type',
1920
example=faker.random_element(["Customer", "Training", "Internal"]),
2021
),
21-
'description': fields.String(
22+
'description': NullableString(
2223
title='Description',
2324
required=False,
2425
max_length=250,

time_tracker_api/projects/projects_namespace.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
from flask_restplus import Resource, fields
33
from flask_restplus._http import HTTPStatus
44

5-
from time_tracker_api.api import common_fields, create_attributes_filter, UUID, api, remove_required_constraint
5+
from time_tracker_api.api import common_fields, create_attributes_filter, UUID, api, remove_required_constraint, \
6+
NullableString
67
from time_tracker_api.projects.projects_model import create_dao
78

89
faker = Faker()
@@ -18,7 +19,7 @@
1819
description='Name of the project',
1920
example=faker.company(),
2021
),
21-
'description': fields.String(
22+
'description': NullableString(
2223
title='Description',
2324
required=False,
2425
max_length=250,

time_tracker_api/time_entries/time_entries_namespace.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
description='The id of the selected activity',
3636
example=faker.uuid4(),
3737
),
38-
'description': fields.String(
38+
'description': NullableString(
3939
title='Comments',
4040
required=False,
4141
description='Comments about the time entry',

0 commit comments

Comments
 (0)