refactor: TT-352 refactoring of use cases and enpoint to obtain activities

Author: JosueOb

V2/source/entry_points/flask_api/activities_endpoints.py

@@ -1,18 +1,26 @@
+from V2.source.daos.activities_json_dao import ActivitiesJsonDao
+from V2.source.services.activity_service import ActivityService
 from V2.source import use_cases
 from flask_restplus import Resource
 from http import HTTPStatus
 
+JSON_PATH = './V2/source/activities_data.json'
+
 
 class Activities(Resource):
     def get(self):
-        activities = use_cases.GetActivitiesUseCase()
+        activity_json = ActivitiesJsonDao(JSON_PATH)
+        activity_service = ActivityService(activity_json)
+        activities = use_cases.GetActivitiesUseCase(activity_service)
         return [activity.__dict__ for activity in activities.get_activities()]
 
 
 class Activity(Resource):
     def get(self, activity_id: str):
         try:
-            activity = use_cases.GetActivityUseCase()
+            activity_json = ActivitiesJsonDao(JSON_PATH)
+            activity_service = ActivityService(activity_json)
+            activity = use_cases.GetActivityUseCase(activity_service)
             return activity.get_activity_by_id(activity_id).__dict__
         except AttributeError:
             return {'message': 'Activity not found'}, HTTPStatus.NOT_FOUND

V2/source/use_cases/_get_activities_use_case.py

@@ -1,11 +1,11 @@
 from V2.source.services.activity_service import ActivityService
-from V2.source.daos.activities_json_dao import ActivitiesJsonDao
 from V2.source.dtos.activity import Activity
 import typing
 
 
 class GetActivitiesUseCase:
+    def __init__(self, activity_service: ActivityService):
+        self.activity_service = activity_service
+
     def get_activities(self) -> typing.List[Activity]:
-        activity_json = ActivitiesJsonDao('./V2/source/activities_data.json')
-        activities = ActivityService(activity_json)
-        return activities.get_all()
+        return self.activity_service.get_all()

V2/source/use_cases/_get_activity_by_id_use_case.py

@@ -1,10 +1,10 @@
 from V2.source.services.activity_service import ActivityService
-from V2.source.daos.activities_json_dao import ActivitiesJsonDao
 from V2.source.dtos.activity import Activity
 
 
 class GetActivityUseCase:
+    def __init__(self, activity_service: ActivityService):
+        self.activity_service = activity_service
+
     def get_activity_by_id(self, id: str) -> Activity:
-        activity_json = ActivitiesJsonDao('./V2/source/activities_data.json')
-        activity = ActivityService(activity_json)
-        return activity.get_by_id(id)
+        return self.activity_service.get_by_id(id)