feat: TT-404 add method get_by_id and get all in _data_persistence

Author: scastillo-jp

V2/serverless.yml

@@ -77,14 +77,14 @@ functions:
           route: activities/
           authLevel: anonymous
 
-  get_activities:
+  get_time_entries:
     handler: time_tracker/time_entries/interface.get_time_entries
     events:
       - http: true
         x-azure-settings:
           methods:
             - GET
-          route: activities/{id:?}
+          route: time_entries/{id:?}
           authLevel: anonymous
 
 

V2/time_tracker/time_entries/_application/__init__.py

@@ -1 +1,2 @@
-from ._time_entries import create_time_entry, get_time_entries
+from ._time_entries import create_time_entry
+from ._time_entries import get_time_entries

V2/time_tracker/time_entries/_application/_time_entries/_get_time_entries.py

@@ -3,17 +3,13 @@
 
 import azure.functions as func
 import json
-import logging
 
 JSON_PATH = (
     'time_entries/_infrastructure/_data_persistence/time_entries_data.json'
 )
 
 def get_time_entries(req: func.HttpRequest) -> func.HttpResponse:
-    logging.info(
-        'Python HTTP trigger function processed a request to get an activity.'
-    )
-    #  WIP
+
     time_entry_id = req.route_params.get('id')
     status_code = 200
 
@@ -51,5 +47,5 @@ def _get_all() -> str:
 
 
 def _create_time_entry_service(path: str):
-    activity_json = TimeEntriesJsonDao(path)
-    return TimeEntryService(activity_json)
+    time_entry_json = TimeEntriesJsonDao(path)
+    return TimeEntryService(time_entry_json)

V2/time_tracker/time_entries/_domain/__init__.py

@@ -3,4 +3,6 @@
 from ._services import TimeEntryService
 from ._use_cases import (
     CreateTimeEntryUseCase,
+    GetTimeEntriesUseCase,
+    GetTimeEntryUseCase
 )

V2/time_tracker/time_entries/_domain/_persistence_contracts/_time_entries_dao.py

@@ -12,5 +12,6 @@ def get_by_id(self, id: str) -> TimeEntry:
     def get_all(self) -> typing.List[TimeEntry]:
         pass
 
+    @abc.abstractmethod
     def create(self, time_entry_data: dict) -> TimeEntry:
         pass

V2/time_tracker/time_entries/_infrastructure/_data_persistence/_time_entries_dao.py

@@ -6,11 +6,25 @@
 
 class TimeEntriesJsonDao(TimeEntriesDao):
 
-  def __init__(self, json_data_file_path: str):
-      self.json_data_file_path = json_data_file_path
-      self.time_entry_key = [field.name for field in dataclasses.fields(TimeEntry)]
+    def __init__(self, json_data_file_path: str):
+        self.json_data_file_path = json_data_file_path
+        self.time_entry_key = [field.name for field in dataclasses.fields(TimeEntry)]
 
-  def create(self, time_entry_data: dict) -> TimeEntry:
+    def get_by_id(self, id: str) -> TimeEntry:
+        time_entry = {
+            time_entry.get('id'): time_entry
+            for time_entry in self.__get_time_entries_from_file()
+        }.get(id)
+
+        return self.__create_time_entry_dto(time_entry) if time_entry else None
+
+    def get_all(self) -> typing.List[TimeEntry]:
+        return [
+            self.__create_time_entry_dto(activity)
+            for activity in self.__get_time_entries_from_file()
+        ]
+
+    def create(self, time_entry_data: dict) -> TimeEntry:
         time_entries = self.__get_time_entries_from_file()
         time_entries.append(time_entry_data)
 
@@ -22,17 +36,17 @@ def create(self, time_entry_data: dict) -> TimeEntry:
         except FileNotFoundError:
             print("Can not create activity")
 
-  def __get_time_entries_from_file(self) -> typing.List[dict]:
-    try:
-        file = open(self.json_data_file_path)
-        time_entries = json.load(file)
-        file.close()
+    def __get_time_entries_from_file(self) -> typing.List[dict]:
+        try:
+            file = open(self.json_data_file_path)
+            time_entries = json.load(file)
+            file.close()
 
-        return time_entries
+            return time_entries
 
-    except FileNotFoundError:
-        return []
+        except FileNotFoundError:
+            return []
 
-  def __create_time_entry_dto(self, time_entry: dict) -> TimeEntry:
+    def __create_time_entry_dto(self, time_entry: dict) -> TimeEntry:
         time_entry = {key: time_entry.get(key) for key in self.time_entry_key}
         return TimeEntry(**time_entry)