feat: TT-243 Fixing code smells

jcalarcon98 · jcalarcon98 · commit b2f3d37fdfb1 · 2021-06-04T17:24:10.000-05:00
diff --git a/tests/time_tracker_api/time_entries/time_entries_query_builder_test.py b/tests/time_tracker_api/time_entries/time_entries_query_builder_test.py
@@ -16,17 +16,19 @@ def test_TimeEntryQueryBuilder_is_subclass_CosmosDBQueryBuilder():
 
 
 def test_add_sql_date_range_condition_should_update_where_list():
+    start_date = "2021-03-19T05:07:00.000Z"
+    end_date = "2021-03-25T10:00:00.000Z"
     time_entry_query_builder = (
         TimeEntryQueryBuilder().add_sql_date_range_condition(
             {
-                "start_date": "2021-03-19T05:07:00.000Z",
-                "end_date": "2021-03-25T10:00:00.000Z",
+                "start_date": start_date,
+                "end_date": end_date,
             }
         )
     )
     expected_params = [
-        {"name": "@start_date", "value": "2021-03-19T05:07:00.000Z"},
-        {"name": "@end_date", "value": "2021-03-25T10:00:00.000Z"},
+        {"name": "@start_date", "value": start_date},
+        {"name": "@end_date", "value": end_date},
     ]
     assert len(time_entry_query_builder.where_conditions) == 1
     assert len(time_entry_query_builder.parameters) == len(expected_params)

Original file line number	Diff line number	Diff line change
`@@ -16,17 +16,19 @@ def test_TimeEntryQueryBuilder_is_subclass_CosmosDBQueryBuilder():`
`16`	`16`
`17`	`17`
`18`	`18`	`def test_add_sql_date_range_condition_should_update_where_list():`
	`19`	`+ start_date = "2021-03-19T05:07:00.000Z"`
	`20`	`+ end_date = "2021-03-25T10:00:00.000Z"`
`19`	`21`	`time_entry_query_builder = (`
`20`	`22`	`TimeEntryQueryBuilder().add_sql_date_range_condition(`
`21`	`23`	`{`
`22`		`- "start_date": "2021-03-19T05:07:00.000Z",`
`23`		`- "end_date": "2021-03-25T10:00:00.000Z",`
	`24`	`+ "start_date": start_date,`
	`25`	`+ "end_date": end_date,`
`24`	`26`	`}`
`25`	`27`	`)`
`26`	`28`	`)`
`27`	`29`	`expected_params = [`
`28`		`- {"name": "@start_date", "value": "2021-03-19T05:07:00.000Z"},`
`29`		`- {"name": "@end_date", "value": "2021-03-25T10:00:00.000Z"},`
	`30`	`+ {"name": "@start_date", "value": start_date},`
	`31`	`+ {"name": "@end_date", "value": end_date},`
`30`	`32`	`]`
`31`	`33`	`assert len(time_entry_query_builder.where_conditions) == 1`
`32`	`34`	`assert len(time_entry_query_builder.parameters) == len(expected_params)`