Skip to content

Commit a993721

Browse files
committed
solve requested changes
1 parent 76a35bf commit a993721

File tree

4 files changed

+35
-5
lines changed

4 files changed

+35
-5
lines changed

V2/tests/api/azure/activity_azure_endpoints_test.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,5 @@ def test__activity_azure_endpoint__creates_an_activity__when_activity_has_all_at
9797

9898
response = activities.create_activity(req)
9999
activitiy_json_data = response.get_body()
100-
print(response)
101100
assert response.status_code == 201
102101
assert activitiy_json_data == body
Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
from time_entries._infrastructure import ActivitiesJsonDao
2+
from time_entries._domain import Activity
3+
from sqlalchemy import create_engine, MetaData
4+
import pytest
5+
import typing
6+
7+
@pytest.fixture(name='create_fake_activities')
8+
def _create_fake_activities(mocker) -> typing.List[Activity]:
9+
def _creator(activities):
10+
read_data = json.dumps(activities)
11+
mocker.patch('builtins.open', mocker.mock_open(read_data=read_data))
12+
return [Activity(**activity) for activity in activities]
13+
14+
return _creator
15+
16+
def test_get_by_id__returns_an_activity_dto__when_found_one_activity_that_matches_its_id():
17+
pass
18+
19+
def test__get_by_id__returns_none__when_no_activity_matches_its_id():
20+
pass
21+
22+
def test__get_all__returns_a_list_of_activity_dto_objects__when_one_or_more_activities_are_found():
23+
pass
24+
25+
def test_get_all__returns_an_empty_list__when_doesnt_found_any_activities():
26+
pass
27+
28+
def test_delete__returns_an_activity_with_inactive_status__when_an_activity_matching_its_id_is_found():
29+
pass
30+
31+
def test_delete__returns_none__when_no_activity_matching_its_id_is_found():
32+
pass
33+
34+
35+

V2/time_entries/_application/_activities/_create_activity.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ def create_activity(req: func.HttpRequest) -> func.HttpResponse:
2121
'Python HTTP trigger function processed a request to create an activity.'
2222
)
2323
activity_data = req.get_json()
24-
print(activity_data)
2524
validation_errors = _validate_activity(activity_data)
2625
if validation_errors:
2726
return func.HttpResponse(
@@ -37,8 +36,6 @@ def create_activity(req: func.HttpRequest) -> func.HttpResponse:
3736
)
3837

3938
created_activity = use_case.create_activity(activity_to_create.__dict__)
40-
print("actividad mapeada",activity_to_create)
41-
print("use case",created_activity)
4239
if not create_activity:
4340
return func.HttpResponse(
4441
body={'error': 'activity could not be created'},

V2/time_entries/_infrastructure/_data_persistence/_activities_json_dao.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ def create_activity(self, activity_data: dict) -> Activity:
9292
def __get_activities_from_file(self) -> typing.List[dict]:
9393
try:
9494
file = open(self.json_data_file_path)
95-
print("")
9695
activities = json.load(file)
9796
file.close()
9897

0 commit comments

Comments
 (0)