Skip to content

Commit a936f0a

Browse files
committed
refactor: TT-352 use list comprehensions
1 parent 408c016 commit a936f0a

File tree

2 files changed

+5
-32
lines changed

2 files changed

+5
-32
lines changed

V2/source/use_cases/get_activities_use_case.py

Lines changed: 3 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -4,23 +4,7 @@
44
def get_list_activities():
55
activity_json_dao = ActivitiesJsonDao('./V2/source/activities_data.json')
66
activity_service = ActivityService(activity_json_dao)
7-
list_activities_dto = activity_service.get_all()
8-
#print(list_activities_dto)
7+
activities_dto = activity_service.get_all()
8+
activities = [activity_dto.__dict__ for activity_dto in activities_dto]
99

10-
list_activities_json = []
11-
12-
for activity_dto in list_activities_dto:
13-
activity_json = {
14-
'id': activity_dto.id,
15-
'name': activity_dto.name,
16-
'description': activity_dto.description,
17-
'deleted': activity_dto.deleted,
18-
'status': activity_dto.status,
19-
'tenant_id': activity_dto.tenant_id,
20-
21-
}
22-
list_activities_json.append(activity_json)
23-
24-
#print(list_activities_json)
25-
26-
return list_activities_json
10+
return activities

V2/source/use_cases/get_activity_by_id_use_case.py

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,6 @@ def get_activity_by_id(id: str):
55
activity_json_dao = ActivitiesJsonDao('./V2/source/activities_data.json')
66
activity_service = ActivityService(activity_json_dao)
77
activity_dto = activity_service.get_by_id(id)
8-
#print(activity_dto)
8+
activity = activity_dto.__dict__
99

10-
activity_json = {
11-
'id': activity_dto.id,
12-
'name': activity_dto.name,
13-
'description': activity_dto.description,
14-
'deleted': activity_dto.deleted,
15-
'status': activity_dto.status,
16-
'tenant_id': activity_dto.tenant_id,
17-
18-
}
19-
#print(activity_json)
20-
21-
return activity_json
10+
return activity

0 commit comments

Comments
 (0)