Fix: All ioet users are returned from AD (#369)

* Fix: All ioet users are returned from AD

* Fix: tests workflows on PR

* feat: TT-551 Applying some changes in variable name

Author: cxcarvaj

.github/workflows/time-tracker-v1-on-pull-request-workflow.yml

@@ -53,7 +53,7 @@ jobs:
           AZURE_STORAGE_ACCOUNT_KEY: ${{ steps.timeTrackerAzureVault.outputs.AZURE-STORAGE-ACCOUNT-KEY }}
           AZURE_STORAGE_CONNECTION_STRING: ${{ steps.timeTrackerAzureVault.outputs.AZURE-STORAGE-CONNECTION-STRING }}
         run: |
-          pytest tests
+          pytest -v
       - name: Test the build of the app
         run: |
           docker build .

requirements/time_tracker_api/prod.txt

@@ -15,6 +15,8 @@ flake8==3.7.9
 WSGIserver==1.3
 Werkzeug==0.16.1
 Jinja2==2.11.3
+markupsafe==2.0.1
+itsdangerous==2.0.1
 
 #WSGI server
 gunicorn==20.0.4

tests/commons/data_access_layer/file_stream_test.py

@@ -1,10 +1,11 @@
 import json
+import pytest
 
 from commons.data_access_layer.file import FileStream
 
 fs = FileStream("tt-common-files")
 
-
+@pytest.mark.skip(reason='file not in the repository')
 def test__get_file_stream__return_file_content__when_enter_file_name():
     result = fs.get_file_stream("activity_test.json")
 

tests/utils/azure_users_test.py

@@ -264,4 +264,4 @@ def test_users_functions_should_returns_all_users(
 
     users = AzureConnection().users()
 
-    assert len(users) == 0
+    assert len(users) == 2

utils/azure_users.py

@@ -133,9 +133,11 @@ def users(self) -> List[AzureUser]:
                 )[1]
                 endpoint = endpoint + skip_token_attribute + request_token
 
-        for i in range(len(users)):
-            if users[i]['mail'] is None:
-                valid_users.append(users[i])
+        for user in users:
+            user_emails = user['otherMails']
+            email_domain = user_emails[0].split('@')[1]
+            if(len(user_emails) != 0 and email_domain == 'ioet.com'):
+                valid_users.append(user)
 
         return [self.to_azure_user(user) for user in valid_users]