test: TT-156 update tests

Author: Angeluz-07

tests/time_tracker_api/users/users_namespace_test.py

@@ -10,14 +10,13 @@
 @patch('utils.azure_users.AzureConnection.get_token', Mock())
 @patch('utils.azure_users.AzureConnection.get_user')
 def test_get_user_response_contains_expected_props(
-    get_user_mock,
-    client: FlaskClient,
-    valid_header: dict,
+    get_user_mock, client: FlaskClient, valid_header: dict,
 ):
     get_user_mock.return_value = {
         'name': 'dummy',
         'email': 'dummy',
         'roles': ['dummy-role'],
+        'groups': ['dummy-group'],
     }
     user_id = (Faker().uuid4(),)
     response = client.get(f'/users/{user_id}', headers=valid_header)
@@ -27,7 +26,9 @@ def test_get_user_response_contains_expected_props(
     assert 'name' in json.loads(response.data)
     assert 'email' in json.loads(response.data)
     assert 'roles' in json.loads(response.data)
+    assert 'groups' in json.loads(response.data)
     assert ['dummy-role'] == json.loads(response.data)['roles']
+    assert ['dummy-group'] == json.loads(response.data)['groups']
 
 
 @patch('utils.azure_users.AzureConnection.get_msal_client', Mock())
@@ -37,12 +38,15 @@ def test_get_user_response_contains_expected_props(
 )
 @patch('utils.azure_users.AzureConnection.users')
 def test_users_response_contains_expected_props(
-    users_mock,
-    client: FlaskClient,
-    valid_header: dict,
+    users_mock, client: FlaskClient, valid_header: dict,
 ):
     users_mock.return_value = [
-        {'name': 'dummy', 'email': 'dummy', 'roles': ['dummy-role']}
+        {
+            'name': 'dummy',
+            'email': 'dummy',
+            'roles': ['dummy-role'],
+            'groups': ['dummy-group'],
+        }
     ]
     response = client.get('/users', headers=valid_header)
 
@@ -51,15 +55,16 @@ def test_users_response_contains_expected_props(
     assert 'name' in json.loads(response.data)[0]
     assert 'email' in json.loads(response.data)[0]
     assert 'roles' in json.loads(response.data)[0]
+    assert 'groups' in json.loads(response.data)[0]
     assert ['dummy-role'] == json.loads(response.data)[0]['roles']
+    assert ['dummy-group'] == json.loads(response.data)[0]['groups']
 
 
 @patch('utils.azure_users.AzureConnection.get_msal_client', Mock())
 @patch('utils.azure_users.AzureConnection.get_token', Mock())
 @patch('utils.azure_users.AzureConnection.update_role')
 @mark.parametrize(
-    'role_id,action',
-    [('test', 'grant'), ('admin', 'revoke')],
+    'role_id,action', [('test', 'grant'), ('admin', 'revoke')],
 )
 def test_update_role_response_contains_expected_props(
     update_role_mock,
@@ -73,15 +78,16 @@ def test_update_role_response_contains_expected_props(
         'name': 'dummy',
         'email': 'dummy',
         'roles': [],
+        'groups': [],
     }
     response = client.post(
-        f'/users/{user_id}/roles/{role_id}/{action}',
-        headers=valid_header,
+        f'/users/{user_id}/roles/{role_id}/{action}', headers=valid_header,
     )
     assert HTTPStatus.OK == response.status_code
     assert 'name' in json.loads(response.data)
     assert 'email' in json.loads(response.data)
     assert 'roles' in json.loads(response.data)
+    assert 'groups' in json.loads(response.data)
 
 
 @patch('utils.azure_users.AzureConnection.get_msal_client', Mock())
@@ -107,8 +113,7 @@ def test_update_role_is_called_properly_on_each_action(
 ):
     update_role_mock.return_value = {}
     response = client.post(
-        f'/users/{user_id}/roles/{role_id}/{action}',
-        headers=valid_header,
+        f'/users/{user_id}/roles/{role_id}/{action}', headers=valid_header,
     )
 
     assert HTTPStatus.OK == response.status_code

tests/utils/azure_users_test.py

@@ -14,10 +14,7 @@
     ],
 )
 def test_azure_connection_is_test_user(
-    get_mock,
-    field_name,
-    field_value,
-    is_test_user_expected_value,
+    get_mock, field_name, field_value, is_test_user_expected_value,
 ):
     response_mock = Mock()
     response_mock.status_code = 200
@@ -36,12 +33,7 @@ def test_azure_connection_get_test_user_ids(get_mock):
     response_mock = Mock()
     response_mock.status_code = 200
     response_mock.json = Mock(
-        return_value={
-            'value': [
-                {'objectId': 'ID1'},
-                {'objectId': 'ID2'},
-            ]
-        }
+        return_value={'value': [{'objectId': 'ID1'}, {'objectId': 'ID2'},]}
     )
     get_mock.return_value = response_mock
 
@@ -57,8 +49,8 @@ def test_azure_connection_get_test_user_ids(get_mock):
 def test_azure_connection_get_non_test_users(
     users_mock, get_test_user_ids_mock
 ):
-    test_user = AzureUser('ID1', None, None, [])
-    non_test_user = AzureUser('ID2', None, None, [])
+    test_user = AzureUser('ID1', None, None, [], [])
+    non_test_user = AzureUser('ID2', None, None, [], [])
     users_mock.return_value = [test_user, non_test_user]
     get_test_user_ids_mock.return_value = ['ID1']
     non_test_users = [non_test_user]