fix: TT-131 extract MSAL client to method

Author: Angeluz-07

tests/time_tracker_api/users/users_namespace_test.py

@@ -5,7 +5,7 @@
 from pytest import mark
 
 
-@patch('msal.ConfidentialClientApplication', Mock())
+@patch('utils.azure_users.AzureConnection.get_msal_client', Mock())
 @patch('utils.azure_users.AzureConnection.get_token', Mock())
 @patch(
     'utils.azure_users.AzureConnection.is_test_user', Mock(return_value=True)
@@ -27,6 +27,8 @@ def test_users_response_contains_expected_props(
     assert ['dummy-role'] == json.loads(response.data)[0]['roles']
 
 
+@patch('utils.azure_users.AzureConnection.get_msal_client', Mock())
+@patch('utils.azure_users.AzureConnection.get_token', Mock())
 @patch('utils.azure_users.AzureConnection.update_role')
 @mark.parametrize(
     'role_id,action', [('test', 'grant'), ('admin', 'revoke')],
@@ -53,6 +55,8 @@ def test_update_role_response_contains_expected_props(
     assert 'roles' in json.loads(response.data)
 
 
+@patch('utils.azure_users.AzureConnection.get_msal_client', Mock())
+@patch('utils.azure_users.AzureConnection.get_token', Mock())
 @patch('utils.azure_users.AzureConnection.update_role', new_callable=Mock)
 @mark.parametrize(
     'role_id,action,is_grant',

tests/utils/azure_users_test.py

@@ -3,7 +3,7 @@
 from pytest import mark
 
 
-@patch('msal.ConfidentialClientApplication', Mock())
+@patch('utils.azure_users.AzureConnection.get_msal_client', Mock())
 @patch('utils.azure_users.AzureConnection.get_token', Mock())
 @patch('requests.get')
 @mark.parametrize(
@@ -26,7 +26,7 @@ def test_azure_connection_is_test_user(
     assert az_conn.is_test_user(test_user_id) == is_test_user_expected_value
 
 
-@patch('msal.ConfidentialClientApplication', Mock())
+@patch('utils.azure_users.AzureConnection.get_msal_client', Mock())
 @patch('utils.azure_users.AzureConnection.get_token', Mock())
 @patch('requests.get')
 def test_azure_connection_get_test_user_ids(get_mock):
@@ -42,7 +42,7 @@ def test_azure_connection_get_test_user_ids(get_mock):
     assert az_conn.get_test_user_ids() == ids
 
 
-@patch('msal.ConfidentialClientApplication', Mock())
+@patch('utils.azure_users.AzureConnection.get_msal_client', Mock())
 @patch('utils.azure_users.AzureConnection.get_token', Mock())
 @patch('utils.azure_users.AzureConnection.get_test_user_ids')
 @patch('utils.azure_users.AzureConnection.users')

utils/azure_users.py

@@ -64,14 +64,18 @@ def __init__(self, id, name, email, roles):
 
 class AzureConnection:
     def __init__(self, config=MSConfig):
-        self.client = msal.ConfidentialClientApplication(
-            config.CLIENT_ID,
-            authority=config.AUTHORITY,
-            client_credential=config.SECRET,
-        )
         self.config = config
+        self.client = self.get_msal_client()
         self.access_token = self.get_token()
 
+    def get_msal_client(self):
+        client = msal.ConfidentialClientApplication(
+            self.config.CLIENT_ID,
+            authority=self.config.AUTHORITY,
+            client_credential=self.config.SECRET,
+        )
+        return client
+
     def get_token(self):
         response = self.client.acquire_token_for_client(
             scopes=self.config.SCOPE