fix: TT-404 search by int in get_by_id

Author: Jobzi

V2/tests/api/azure/time_entry_azure_endpoints_test.py

@@ -38,3 +38,21 @@ def test__time_entry_azure_endpoint__returns_an_time_entry__when_time_entry_matc
 
     assert response.status_code == 200
     assert time_entry_json_data == json.dumps(time_entries_json[0])
+
+
+def test__get_time_entries_azure_endpoint__returns_a_status_code_400__when_time_entry_recive_invalid_id(
+    create_temp_time_entries,
+):
+    tmp_directory = create_temp_time_entries
+    time_entries._get_time_entries.JSON_PATH = tmp_directory
+    req = func.HttpRequest(
+        method="GET",
+        body=None,
+        url=TIME_ENTRY_URL,
+        route_params={"id": "invalid id"},
+    )
+
+    response = time_entries.get_time_entries(req)
+
+    assert response.status_code == 400
+    assert response.get_body() == b'Invalid Format ID'

V2/tests/integration/daos/time_entries_json_dao_test.py

@@ -8,7 +8,7 @@
 
 fake_time_entries = [
     {
-        "id": Faker().uuid4(),
+        "id": Faker().pyint(),
         "start_date": str(Faker().date_time()),
         "owner_id": Faker().uuid4(),
         "description": Faker().sentence(),

V2/time_tracker/time_entries/_application/_time_entries/_get_time_entries.py

@@ -15,9 +15,13 @@ def get_time_entries(req: func.HttpRequest) -> func.HttpResponse:
     status_code = 200
 
     if time_entry_id:
-        response = _get_by_id(time_entry_id)
-        if response == b'Not Found':
-            status_code = 404
+        try:
+            response = _get_by_id(int(time_entry_id))
+            if response == b'Not Found':
+                status_code = 404
+        except ValueError:
+            response = b'Invalid Format ID'
+            status_code = 400
     else:
         response = _get_all()
 
@@ -26,7 +30,7 @@ def get_time_entries(req: func.HttpRequest) -> func.HttpResponse:
     )
 
 
-def _get_by_id(id: str) -> str:
+def _get_by_id(id: int) -> str:
     time_entry_use_case = _use_cases.GetTimeEntryUseCase(
         _create_time_entry_service(JSON_PATH)
     )

V2/time_tracker/time_entries/_domain/_persistence_contracts/_time_entries_dao.py

@@ -6,7 +6,7 @@
 
 class TimeEntriesDao(abc.ABC):
     @abc.abstractmethod
-    def get_by_id(self, id: str) -> TimeEntry:
+    def get_by_id(self, id: int) -> TimeEntry:
         pass
 
     @abc.abstractmethod

V2/time_tracker/time_entries/_domain/_services/_time_entry.py

@@ -6,7 +6,7 @@ class TimeEntryService:
     def __init__(self, time_entry_dao: TimeEntriesDao):
         self.time_entry_dao = time_entry_dao
 
-    def get_by_id(self, id: str) -> TimeEntry:
+    def get_by_id(self, id: int) -> TimeEntry:
         return self.time_entry_dao.get_by_id(id)
 
     def get_all(self) -> typing.List[TimeEntry]:

V2/time_tracker/time_entries/_domain/_use_cases/_get_time_entry_by_id_use_case.py

@@ -5,5 +5,5 @@ class GetTimeEntryUseCase:
     def __init__(self, time_entry_service: TimeEntryService):
         self.time_entry_service = time_entry_service
 
-    def get_time_entry_by_id(self, id: str) -> TimeEntry:
+    def get_time_entry_by_id(self, id: int) -> TimeEntry:
         return self.time_entry_service.get_by_id(id)

V2/time_tracker/time_entries/_infrastructure/_data_persistence/_time_entries_dao.py

@@ -11,7 +11,7 @@ def __init__(self, json_data_file_path: str):
         self.json_data_file_path = json_data_file_path
         self.time_entry_key = [field.name for field in dataclasses.fields(TimeEntry)]
 
-    def get_by_id(self, id: str) -> TimeEntry:
+    def get_by_id(self, id: int) -> TimeEntry:
         time_entry = {
             time_entry.get('id'): time_entry
             for time_entry in self.__get_time_entries_from_file()

V2/time_tracker/time_entries/_infrastructure/_data_persistence/time_entries_data.json

@@ -1,5 +1,5 @@
 [{
-  "id": "c61a4a49-3364-49a3-a7f7-0c5f2d15072b",
+  "id": 1,
   "start_date": "12/07/2021",
   "owner_id": 2,
   "tenant_id": "asdasdsa",
@@ -12,7 +12,7 @@
   "timezone_offset": "asdasdsa",
   "project_id": 1
 }, {
-  "id": "c61a4a49-3364-49a3-a7f7-0c5f2d15072c",
+  "id": 2,
   "start_date": "12/07/2021",
   "owner_id": 2,
   "tenant_id": "asdasdsa",
@@ -25,7 +25,7 @@
   "timezone_offset": "asdasdsa",
   "project_id": 1
 }, {
-  "id": "c61a4a49-3364-49a3-a7f7-0c5f2d15072e",
+  "id": 3,
   "start_date": "12/07/2021",
   "owner_id": 2,
   "tenant_id": "asdasdsa",
@@ -38,7 +38,7 @@
   "timezone_offset": "asdasdsa",
   "project_id": 1
 }, {
-  "id": "c61a4a49-3364-49a3-a7f7-0c5f2d15072f",
+  "id": 4,
   "start_date": "12/07/2021",
   "owner_id": 2,
   "tenant_id": "asdasdsa",
@@ -51,7 +51,7 @@
   "timezone_offset": "asdasdsa",
   "project_id": 1
 }, {
-  "id": "c61a4a49-3364-49a3-a7f7-0c5f2d15072g",
+  "id": 5,
   "start_date": "12/07/2021",
   "owner_id": 2,
   "tenant_id": "asdasdsa",
@@ -64,7 +64,7 @@
   "timezone_offset": "asdasdsa",
   "project_id": 1
 }, {
-  "id": "c61a4a49-3364-49a3-a7f7-0c5f2d15072h",
+  "id": 6,
   "start_date": "12/07/2021",
   "owner_id": 2,
   "tenant_id": "asdasdsa",
@@ -77,7 +77,7 @@
   "timezone_offset": "asdasdsa",
   "project_id": 1
 }, {
-  "id": "c61a4a49-3364-49a3-a7f7-0c5f2d15072i",
+  "id": 7,
   "start_date": "12/07/2021",
   "owner_id": 2,
   "tenant_id": "asdasdsa",