refactor: TT-352 improvement of endpoint testing for obtaining activities

Author: JosueOb

V2/tests/entry_points/flask_api/activities_endpoints_test.py renamed to V2/tests/api/flask/activity_endpoints_test.py

@@ -31,9 +31,10 @@ def client():
         yield client
 
 
-def test__activities_class__uses_the_get_activities_use_case__to_retrieve_activities(client: FlaskClient,
-                                                                                     mocker: MockFixture):
-    use_cases.get_list_activities = mocker.Mock(return_value=[])
+def test__activity_endpoint__returns_all_activities(
+    client: FlaskClient, mocker: MockFixture
+):
+    mocker.patch('V2.source.use_cases.get_list_activities', return_value=[])
 
     response = client.get("/activities/")
     json_data = json.loads(response.data)
@@ -42,19 +43,27 @@ def test__activities_class__uses_the_get_activities_use_case__to_retrieve_activi
     assert [] == json_data
 
 
-def test__activity_class__returns_an_activity__when_activity_matches_its_id(client: FlaskClient, mocker: MockFixture):
-    use_cases.get_activity_by_id = mocker.Mock(return_value=fake_activity_dto)
+def test__activity_endpoint__returns_an_activity__when_activity_matches_its_id(
+    client: FlaskClient, mocker: MockFixture
+):
+    mocker.patch(
+        'V2.source.use_cases.get_activity_by_id',
+        return_value=fake_activity_dto,
+    )
 
     response = client.get("/activities/%s" % valid_id)
 
     assert response.status_code == HTTPStatus.OK
     assert fake_activity == json.loads(response.data)
 
 
-def test__activity_class__returns_an_activity__when_no_activity_matches_its_id(client: FlaskClient,
-                                                                               mocker: MockFixture):
+def test__activity_endpoint__returns_a_not_found_status__when_no_activity_matches_its_id(
+    client: FlaskClient, mocker: MockFixture
+):
     invalid_id = fake.uuid4()
-    use_cases.get_activity_by_id = mocker.Mock(side_effect=NotFound)
+    mocker.patch(
+        'V2.source.use_cases.get_activity_by_id', side_effect=NotFound
+    )
 
     response = client.get("/activities/%s" % invalid_id)
 

V2/tests/daos/activities_json_dao_test.py renamed to V2/tests/integration/daos/activities_json_dao_test.py

@@ -0,0 +1,50 @@
+from V2.source.entry_points.flask_api.activities_endpoints import (
+    Activities,
+    Activity,
+)
+from V2.source import use_cases
+from V2.source.dtos.activity import Activity as ActivityDTO
+from pytest_mock import MockFixture
+from faker import Faker
+from werkzeug.exceptions import NotFound
+
+fake = Faker()
+
+valid_id = fake.uuid4()
+
+fake_activity = {
+    "name": fake.company(),
+    "description": fake.paragraph(),
+    "tenant_id": fake.uuid4(),
+    "id": valid_id,
+    "deleted": fake.date(),
+    "status": fake.boolean(),
+}
+fake_activity_dto = ActivityDTO(**fake_activity)
+
+
+def test__activities_class__uses_the_get_activities_use_case__to_retrieve_activities(
+    mocker: MockFixture,
+):
+    mocker.patch('V2.source.use_cases.get_list_activities', return_value=[])
+
+    activities_class_endpoint = Activities()
+    activities = activities_class_endpoint.get()
+
+    assert use_cases.get_list_activities.called
+    assert [] == activities
+
+
+def test__activity_class__uses_the_get_activity_by_id_use_case__to_retrieve__an_activity(
+    mocker: MockFixture,
+):
+    mocker.patch(
+        'V2.source.use_cases.get_activity_by_id',
+        return_value=fake_activity_dto,
+    )
+
+    activity_class_endpoint = Activity()
+    activity = activity_class_endpoint.get(valid_id)
+
+    assert use_cases.get_activity_by_id.called
+    assert fake_activity == activity

V2/tests/unit/entry_points/flask/activity_class_endpoint_test.py

@@ -1,26 +1,33 @@
-import pytest
+from V2.source import use_cases
 from pytest_mock import MockFixture
 from faker import Faker
 
-from V2.source import use_cases
-from V2.source.daos.activities_json_dao import ActivitiesJsonDao
-
 fake = Faker()
 
 
-def test__get_list_activities_function__uses_the_activities_service__to_retrieve_activities(mocker: MockFixture):
+def test__get_list_activities_function__uses_the_activities_service__to_retrieve_activities(
+    mocker: MockFixture,
+):
     expected_activities = mocker.Mock()
-    mocker.patch('V2.source.use_cases.get_list_activities', return_value=expected_activities);
+    mocker.patch(
+        'V2.source.use_cases.get_list_activities',
+        return_value=expected_activities,
+    )
 
     actual_activities = use_cases.get_list_activities()
 
     assert use_cases.get_list_activities.called
     assert expected_activities == actual_activities
 
 
-def test__get_activity_by_id_function__uses_the_activities_service__to_retrieve_activity(mocker: MockFixture):
+def test__get_activity_by_id_function__uses_the_activities_service__to_retrieve_activity(
+    mocker: MockFixture,
+):
     expected_activity = mocker.Mock()
-    mocker.patch('V2.source.use_cases.get_activity_by_id', return_value=expected_activity);
+    mocker.patch(
+        'V2.source.use_cases.get_activity_by_id',
+        return_value=expected_activity,
+    )
 
     actual_activity = use_cases.get_activity_by_id(fake.uuid4())