Skip to content

Commit 7a2565c

Browse files
author
Andrés Soto
committed
refactor: TT-353 Add type of argument and return type to functions
1 parent b15c301 commit 7a2565c

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
1+
from V2.source.dtos.activity import ActivityDto
12
import abc
23

34

45
class ActivitiesDaoInterface(abc.ABC):
56
@abc.abstractmethod
6-
def get_by_id(self, id):
7+
def get_by_id(self, id: str) -> ActivityDto:
78
pass
89

910
@abc.abstractmethod
10-
def get_all(self):
11+
def get_all(self) -> list:
1112
pass

V2/source/daos/activities_json_dao.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55

66

77
class ActivitiesJsonDao(ActivitiesDaoInterface):
8-
def __init__(self, json_data_file_path):
8+
def __init__(self, json_data_file_path: str):
99
self.json_data_file_path = json_data_file_path
1010
self.activity_keys = ActivityDto.__dataclass_fields__.keys()
1111

12-
def get_by_id(self, id):
12+
def get_by_id(self, id: str) -> ActivityDto:
1313
try:
1414
file = open(self.json_data_file_path)
1515
activities = json.load(file)
@@ -31,7 +31,7 @@ def get_by_id(self, id):
3131

3232
return activity_dto
3333

34-
def get_all(self):
34+
def get_all(self) -> list:
3535
try:
3636
file = open(self.json_data_file_path)
3737
activities = json.load(file)
Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,18 @@
11
from V2.source.daos.activities_dao_interface import ActivitiesDaoInterface
2+
from V2.source.dtos.activity import ActivityDto
23

34

45
class ActivityService:
56

67
activities_dao: ActivitiesDaoInterface
78

8-
def __init__(self, activities_dao):
9+
def __init__(self, activities_dao: ActivitiesDaoInterface):
910
self.activities_dao = activities_dao
1011

11-
def get_by_id(self, id):
12+
def get_by_id(self, id: str) -> ActivityDto:
1213
activity_dto = self.activities_dao.get_by_id(id)
1314
return activity_dto
1415

15-
def get_all(self):
16+
def get_all(self) -> list:
1617
list_activities = self.activities_dao.get_all()
1718
return list_activities

0 commit comments

Comments
 (0)