Skip to content

Commit 6cbb933

Browse files
committed
Fixes #26 - apply PR review suggestions
1 parent 84144a9 commit 6cbb933

File tree

5 files changed

+18
-18
lines changed

5 files changed

+18
-18
lines changed

time_tracker_api/activities/activities_namespace.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@
1313
title='Name',
1414
max_length=50,
1515
description='Canonical name of the activity',
16-
example=faker.word(['Development', 'Training'])
16+
example=faker.word(['Development', 'Training']),
1717
),
1818
'description': fields.String(
1919
title='Description',
2020
description='Comments about the activity',
21-
example=faker.paragraph()
21+
example=faker.paragraph(),
2222
),
2323
})
2424

@@ -28,7 +28,7 @@
2828
required=True,
2929
title='Identifier',
3030
description='The unique identifier',
31-
example=faker.uuid4()
31+
example=faker.random_int(1, 9999),
3232
)
3333
}
3434
activity_response_fields.update(audit_fields)

time_tracker_api/api.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,21 +12,21 @@
1212
readOnly=True,
1313
title='Created',
1414
description='Date of creation',
15-
example=faker.iso8601(end_datetime=None)
15+
example=faker.iso8601(end_datetime=None),
1616
),
1717
'tenant_id': fields.String(
1818
readOnly=True,
1919
title='Tenant',
2020
max_length=64,
2121
description='The tenant this belongs to',
22-
example=faker.uuid4()
22+
example=faker.random_int(1, 9999),
2323
),
2424
'created_by': fields.String(
2525
readOnly=True,
2626
title='Creator',
2727
max_length=64,
2828
description='User that created it',
29-
example=faker.uuid4()
29+
example=faker.random_int(1, 9999),
3030
),
3131
}
3232

time_tracker_api/projects/projects_namespace.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,19 @@
1515
title='Name',
1616
max_length=50,
1717
description='Name of the project',
18-
example=faker.word(['YoSpace', 'Yira'])
18+
example=faker.word(['YoSpace', 'Yira']),
1919
),
2020
'description': fields.String(
2121
title='Description',
2222
description='Description about the project',
23-
example=faker.paragraph()
23+
example=faker.paragraph(),
2424
),
2525
'type': fields.String(
2626
required=True,
2727
title='Type',
2828
max_length=30,
2929
description='If it is `Costumer`, `Training` or other type',
30-
example=faker.word(['Customer', 'Training'])
30+
example=faker.word(['Customer', 'Training']),
3131
),
3232
})
3333

@@ -37,7 +37,7 @@
3737
required=True,
3838
title='Identifier',
3939
description='The unique identifier',
40-
example=faker.uuid4()
40+
example=faker.random_int(1, 9999),
4141
)
4242
}
4343
project_response_fields.update(audit_fields)

time_tracker_api/technologies/technologies_namespace.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
required=True,
2424
title='Identifier',
2525
description='The unique identifier',
26-
example=faker.uuid4()
26+
example=faker.random_int(1, 9999),
2727
),
2828
}
2929
technology_response_fields.update(audit_fields)

time_tracker_api/time_entries/time_entries_namespace.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@
1414
title='Project',
1515
max_length=64,
1616
description='The id of the selected project',
17-
example=faker.uuid4()
17+
example=faker.random_int(1, 9999),
1818
),
1919
'activity_id': fields.String(
2020
required=False,
2121
title='Activity',
2222
max_length=64,
2323
description='The id of the selected activity',
24-
example=faker.uuid4()
24+
example=faker.random_int(1, 9999),
2525
),
2626
'technologies': fields.String(
2727
required=True,
@@ -32,19 +32,19 @@
3232
'description': fields.String(
3333
title='Comments',
3434
description='Comments about the time entry',
35-
example=faker.paragraph()
35+
example=faker.paragraph(),
3636
),
3737
'start_date': fields.DateTime(
3838
required=True,
3939
title='Start date',
4040
description='When the user started doing this activity',
41-
example=faker.iso8601(end_datetime=None)
41+
example=faker.iso8601(end_datetime=None),
4242
),
4343
'end_date': fields.DateTime(
4444
required=True,
4545
title='End date',
4646
description='When the user ended doing this activity',
47-
example=faker.iso8601(end_datetime=None)
47+
example=faker.iso8601(end_datetime=None),
4848
),
4949
})
5050

@@ -54,13 +54,13 @@
5454
required=True,
5555
title='Identifier',
5656
description='The unique identifier',
57-
example=faker.uuid4()
57+
example=faker.random_int(1, 9999),
5858
),
5959
'running': fields.Boolean(
6060
readOnly=True,
6161
title='Is it running?',
6262
description='Whether this time entry is currently running or not',
63-
example=faker.boolean()
63+
example=faker.boolean(),
6464
),
6565
}
6666
time_entry_response_fields.update(audit_fields)

0 commit comments

Comments
 (0)