feat: TT-365 / TT-369 POST V2 Activity (#329)

* feat: TT-365 Method POST activity and create function serverless

* fix: TT-365 resolve comments

* fix: TT-365 format code

Co-authored-by: Sandro Castillo <[email protected]>

Author: dsgarcia8

V2/serverless.yml

@@ -63,6 +63,16 @@ functions:
       - http: true
         x-azure-settings:
           methods:
-            - PUT
+            - PUT   
           route: activities/{id}
+          authLevel: anonymous    
+
+  create_activity:
+    handler: time_entries/interface.create_activity
+    events:
+      - http: true
+        x-azure-settings:
+          methods:
+            - POST
+          route: activities/
           authLevel: anonymous

V2/tests/api/azure/activity_azure_endpoints_test.py

@@ -80,3 +80,22 @@ def test__update_activity_azure_endpoint__returns_an_activity__when_found_an_act
 
     assert response.status_code == 200
     assert activitiy_json_data == json.dumps(new_activity)
+
+def test__activity_azure_endpoint__creates_an_activity__when_activity_has_all_attributes(
+     create_temp_activities,
+ ):
+     activities_json, tmp_directory = create_temp_activities
+     activities._create_activity._JSON_PATH = tmp_directory
+
+     activity_body = {'id': None, 'name': Faker().user_name(), 'description': Faker().sentence(),'deleted': Faker().uuid4() ,'status': 'active', 'tenant_id': Faker().uuid4()}
+     body = json.dumps(activity_body).encode("utf-8")
+     req = func.HttpRequest(
+         method='POST',
+         body= body,
+         url=ACTIVITY_URL,
+     )
+
+     response = activities.create_activity(req)
+     activitiy_json_data = response.get_body()
+     assert response.status_code == 201
+     assert activitiy_json_data ==  body

V2/tests/integration/daos/activities_json_dao_test.py

@@ -132,3 +132,18 @@ def test_update__returns_none__when_doesnt_found_one_activity_to_update(
     result = activities_json_dao.update('', activity_data)
 
     assert result == None
+
+def test_create_activity__returns_an_activity_dto__when_create_an_activity_that_matches_attributes(create_fake_activities):
+     create_fake_activities([])
+
+     activities_json_dao = ActivitiesJsonDao(Faker().file_path())
+     activity_data = {
+         "name": "test_name",
+         "description": "test_description",
+         "tenant_id": "test_tenant_id",
+         "id": "test_id",
+         "deleted": "test_deleted",
+         "status": "test_status",
+     }
+     result = activities_json_dao.create_activity(activity_data)
+     assert result == Activity(**activity_data)

V2/tests/unit/services/activity_service_test.py

@@ -58,3 +58,15 @@ def test__update_activity__uses_the_activity_dao__to_update_one_activity(
 
     assert activity_dao.update.called
     assert expected_activity == updated_activity
+
+def test__create_activity__uses_the_activity_dao__to_create_an_activity(mocker):
+    expected_activity = mocker.Mock()
+    activity_dao = mocker.Mock(
+        create_activity=mocker.Mock(return_value=expected_activity)
+    )
+    activity_service = ActivityService(activity_dao)
+
+    actual_activity = activity_service.create_activity(Faker().pydict())
+
+    assert activity_dao.create_activity.called
+    assert expected_activity == actual_activity

V2/tests/unit/use_cases/activities_use_case_test.py

@@ -36,6 +36,20 @@ def test__get_activity_by_id_function__uses_the_activity_service__to_retrieve_ac
     assert expected_activity == actual_activity
 
 
+def test__create_activity_function__uses_the_activities_service__to_create_activity(
+     mocker: MockFixture,
+ ):
+     expected_activity = mocker.Mock()
+     activity_service = mocker.Mock(
+         create_activity=mocker.Mock(return_value=expected_activity)
+     )
+
+     activity_use_case = _use_cases.CreateActivityUseCase(activity_service)
+     actual_activity = activity_use_case.create_activity(fake.pydict())
+
+     assert activity_service.create_activity.called
+     assert expected_activity == actual_activity
+
 def test__delete_activity_function__uses_the_activity_service__to_change_activity_status(
     mocker: MockFixture,
 ):
@@ -50,7 +64,6 @@ def test__delete_activity_function__uses_the_activity_service__to_change_activit
     assert activity_service.delete.called
     assert expected_activity == deleted_activity
 
-
 def test__update_activity_function__uses_the_activities_service__to_update_an_activity(
     mocker: MockFixture,
 ):

V2/time_entries/_application/__init__.py

@@ -1,3 +1,4 @@
 from ._activities import get_activities
 from ._activities import delete_activity
 from ._activities import update_activity
+from ._activities import create_activity

V2/time_entries/_application/_activities/__init__.py

@@ -1,3 +1,4 @@
 from ._get_activities import get_activities
 from ._delete_activity import delete_activity
 from ._update_activity import update_activity
+from ._create_activity import create_activity

V2/time_entries/_application/_activities/_create_activity.py

@@ -0,0 +1,62 @@
+import json
+import logging
+import dataclasses
+import typing
+
+import azure.functions as func
+
+from ... import _domain
+from ... import _infrastructure
+
+_JSON_PATH = (
+    'time_entries/_infrastructure/_data_persistence/activities_data.json'
+)
+
+
+def create_activity(req: func.HttpRequest) -> func.HttpResponse:
+    activity_dao = _infrastructure.ActivitiesJsonDao(_JSON_PATH)
+    activity_service = _domain.ActivityService(activity_dao)
+    use_case = _domain._use_cases.CreateActivityUseCase(activity_service)
+
+
+    activity_data = req.get_json()
+
+
+    validation_errors = _validate_activity(activity_data)
+    if validation_errors:
+        return func.HttpResponse(
+            body=validation_errors, status_code=400, mimetype="application/json"
+        )
+
+
+    activity_to_create = _domain.Activity(
+        id= None,
+        name=activity_data['name'],
+        description=activity_data['description'],
+        status=activity_data['status'],
+        deleted=activity_data['deleted'],
+        tenant_id=activity_data['tenant_id']
+    )
+
+
+    created_activity = use_case.create_activity(activity_to_create.__dict__)
+    if not create_activity:
+        return func.HttpResponse(
+            body={'error': 'activity could not be created'},
+            status_code=500,
+            mimetype="application/json",
+        )
+    return func.HttpResponse(
+        body=json.dumps(created_activity.__dict__),
+        status_code=201,
+        mimetype="application/json"
+    )
+
+
+def _validate_activity(activity_data: dict) -> typing.List[str]:
+    activity_fields = [field.name for field in dataclasses.fields(_domain.Activity)]
+    missing_keys = [field for field in activity_fields if field not in activity_data]
+    return [
+        f'The {missing_key} key is missing in the input data'
+        for missing_key in missing_keys
+    ]

V2/time_entries/_domain/_persistence_contracts/_activities_dao.py

@@ -19,3 +19,11 @@ def delete(self, id: str) -> Activity:
     @abc.abstractmethod
     def update(self, id: str, new_activity: dict) -> Activity:
         pass
+
+    @abc.abstractmethod
+    def create_activity(self, activity_data: dict) -> Activity:
+        pass
+
+    @abc.abstractmethod
+    def delete(self, id: str) -> Activity:
+        pass

V2/time_entries/_domain/_services/_activity.py

@@ -17,3 +17,6 @@ def delete(self, activity_id: str) -> Activity:
 
     def update(self, activity_id: str, new_activity: dict) -> Activity:
         return self.activities_dao.update(activity_id, new_activity)
+
+    def create_activity(self, activity_data: dict) -> Activity:
+        return self.activities_dao.create_activity(activity_data)