feat: TT-407 tests added

Author: mandres2015

V2/get_lastest_time_entries/function.json V2/get_latest_time_entries/function.jsonV2/get_lastest_time_entries/function.json renamed to V2/get_latest_time_entries/function.json

@@ -5,7 +5,7 @@
       "type": "httpTrigger",
       "direction": "in",
       "name": "req",
-      "route": "time-entries/latest",
+      "route": "time-entries/latest/",
       "authLevel": "anonymous",
       "methods": [
         "GET"

V2/serverless.yml

@@ -1,6 +1,6 @@
 service: azure-time-tracker
 
-frameworkVersion: "2"
+frameworkVersion: '2'
 
 provider:
   name: azure
@@ -23,18 +23,18 @@ plugins:
 
 package:
   patterns:
-    - "!env/**"
-    - "!.env/**"
-    - "!local.settings.json"
-    - "!.vscode/**"
-    - "!__pycache__/**"
-    - "!node_modules/**"
-    - "!.python_packages/**"
-    - "!.funcignore"
-    - "!package.json"
-    - "!package-lock.json"
-    - "!.gitignore"
-    - "!.git/**"
+    - '!env/**'
+    - '!.env/**'
+    - '!local.settings.json'
+    - '!.vscode/**'
+    - '!__pycache__/**'
+    - '!node_modules/**'
+    - '!.python_packages/**'
+    - '!.funcignore'
+    - '!package.json'
+    - '!package-lock.json'
+    - '!.gitignore'
+    - '!.git/**'
 
 functions:
   get_activities:
@@ -63,9 +63,9 @@ functions:
       - http: true
         x-azure-settings:
           methods:
-            - PUT   
+            - PUT
           route: activities/{id}
-          authLevel: anonymous    
+          authLevel: anonymous
 
   create_activity:
     handler: time_tracker/activities/interface.create_activity
@@ -94,5 +94,5 @@ functions:
         x-azure-settings:
           methods:
             - GET
-          route: time-entries/latest
+          route: time-entries/latest/
           authLevel: anonymous

V2/tests/api/azure/time_entry_azure_endpoints_test.py

@@ -1,5 +1,6 @@
 import pytest
 import json
+from faker import Faker
 
 import azure.functions as func
 
@@ -21,43 +22,44 @@ def _new_time_entry(time_entry: domain_time_entries.TimeEntry, database: DB):
     return _new_time_entry
 
 
-def test__delete_time_entries_azure_endpoint__returns_an_time_entry_with_true_deleted__when_its_id_is_found(
+def test__get_latest_entries_azure_endpoint__returns_a_list_of_latest_time_entries__when_an_owner_id_match(
     create_fake_database, time_entry_factory, insert_time_entry, insert_activity, activity_factory,
 ):
     db = create_fake_database
-    azure_time_entries._delete_time_entry.DATABASE = db
+    azure_time_entries._get_latest_entries.DATABASE = db
     inserted_activity = insert_activity(activity_factory(), db).__dict__
     time_entry_body = time_entry_factory(activity_id=inserted_activity["id"], technologies="[jira,sql]")
     inserted_time_entry = insert_time_entry(time_entry_body, db)
 
     req = func.HttpRequest(
-        method='DELETE',
+        method='GET',
         body=None,
-        url=TIME_ENTRY_URL,
-        route_params={"id": inserted_time_entry.id},
+        url=TIME_ENTRY_URL+"latest/",
+        params={"owner_id": inserted_time_entry.owner_id},
     )
 
-    response = azure_time_entries._delete_time_entry.delete_time_entry(req)
+    response = azure_time_entries._get_latest_entries.get_latest_entries(req)
     time_entry_json_data = json.loads(response.get_body().decode("utf-8"))
 
     assert response.status_code == 200
-    assert time_entry_json_data['deleted'] is True
+    assert time_entry_json_data == [inserted_time_entry.__dict__]
 
 
-def test__delete_time_entries_azure_endpoint__returns_a_status_code_400__when_time_entry_recive_invalid_id(
-    create_fake_database,
+def test__get_latest_entries_azure_endpoint__returns_No_time_entries_found__when_recieve_an_invalid_owner_id(
+    create_fake_database, insert_activity, activity_factory,
 ):
     db = create_fake_database
-    azure_time_entries._delete_time_entry.DATABASE = db
+    azure_time_entries._get_latest_entries.DATABASE = db
+    insert_activity(activity_factory(), db)
 
     req = func.HttpRequest(
-        method="DELETE",
+        method='GET',
         body=None,
-        url=TIME_ENTRY_URL,
-        route_params={"id": "invalid id"},
+        url=TIME_ENTRY_URL+"latest/",
+        params={"owner_id": Faker().pyint()},
     )
 
-    response = azure_time_entries._delete_time_entry.delete_time_entry(req)
+    response = azure_time_entries._get_latest_entries.get_latest_entries(req)
 
-    assert response.status_code == 400
-    assert response.get_body() == b'Invalid Format ID'
+    assert response.status_code == 404
+    assert response.get_body() == b'No time entries found'

V2/tests/integration/daos/time_entries_dao_test.py

@@ -13,24 +13,25 @@ def _create_fake_dao() -> domain.TimeEntriesDao:
     return dao
 
 
-def test_delete__returns_an_time_entry_with_true_deleted__when_an_time_entry_matching_its_id_is_found(
+def test_get_latest_entries__returns_a_list_of_latest_time_entries__when_an_owner_id_match(
     create_fake_dao, time_entry_factory, insert_activity, activity_factory
 ):
     dao = create_fake_dao
     inserted_activity = insert_activity(activity_factory(), dao.db)
-    existent_time_entry = time_entry_factory(activity_id=inserted_activity.id, technologies="[jira,sql]")
-    inserted_time_entry = dao.create(existent_time_entry)
+    time_entry_to_insert = time_entry_factory(activity_id=inserted_activity.id, technologies="[jira,sql]")
+    inserted_time_entry = dao.create(time_entry_to_insert)
 
-    result = dao.delete(inserted_time_entry.id)
+    result = dao.get_latest_entries(int(inserted_time_entry.owner_id))
 
-    assert result.deleted is True
+    assert result == [inserted_time_entry.__dict__]
 
 
-def test_delete__returns_none__when_no_time_entry_matching_its_id_is_found(
-    create_fake_dao,
+def test_get_latest_entries__returns_None__when_an_owner_id_is_not_found(
+    create_fake_dao, time_entry_factory, insert_activity, activity_factory
 ):
     dao = create_fake_dao
+    insert_activity(activity_factory(), dao.db)
 
-    result = dao.delete(Faker().pyint())
+    result = dao.get_latest_entries(Faker().pyint())
 
     assert result is None

V2/tests/unit/services/time_entry_service_test.py

@@ -3,16 +3,16 @@
 from time_tracker.time_entries._domain import TimeEntryService
 
 
-def test__delete_time_entry__uses_the_time_entry_dao__to_change_time_entry_deleted(
+def test__get_latest_entries__uses_the_time_entry_dao__to_get_last_entries(
     mocker,
 ):
-    expected_time_entry = mocker.Mock()
+    expected_latest_time_entries = mocker.Mock()
     time_entry_dao = mocker.Mock(
-        delete=mocker.Mock(return_value=expected_time_entry)
+        get_latest_entries=mocker.Mock(return_value=expected_latest_time_entries)
     )
 
     time_entry_service = TimeEntryService(time_entry_dao)
-    deleted_time_entry = time_entry_service.delete(Faker().pyint())
+    latest_time_entries = time_entry_service.get_latest_entries(Faker().pyint(), Faker().pyint())
 
-    assert time_entry_dao.delete.called
-    assert expected_time_entry == deleted_time_entry
+    assert expected_latest_time_entries == latest_time_entries
+    assert time_entry_dao.get_latest_entries.called

V2/tests/unit/use_cases/time_entries_use_case_test.py

@@ -4,14 +4,14 @@
 from time_tracker.time_entries._domain import _use_cases
 
 
-def test__delete_time_entry_function__uses_the_time_entry_service__to_change_time_entry_deleted(
+def test__get_latest_entries_function__uses_the_time_entry_service__to_get_last_entries(
     mocker: MockFixture,
 ):
-    expected_time_entry = mocker.Mock()
-    time_entry_service = mocker.Mock(delete=mocker.Mock(return_value=expected_time_entry))
+    expected_latest_time_entries = mocker.Mock()
+    time_entry_service = mocker.Mock(get_latest_entries=mocker.Mock(return_value=expected_latest_time_entries))
 
-    time_entry_use_case = _use_cases.DeleteTimeEntryUseCase(time_entry_service)
-    deleted_time_entry = time_entry_use_case.delete_time_entry(Faker().pyint())
+    time_entry_use_case = _use_cases.GetLastTimeEntryUseCase(time_entry_service)
+    latest_time_entries = time_entry_use_case.get_latest_entries(Faker().pyint(), Faker().pyint())
 
-    assert time_entry_service.delete.called
-    assert expected_time_entry == deleted_time_entry
+    assert time_entry_service.get_latest_entries.called
+    assert expected_latest_time_entries == latest_time_entries

V2/time_tracker/time_entries/_application/__init__.py

@@ -1,2 +1,2 @@
 # flake8: noqa
-from ._time_entries import delete_time_entry, get_latest_entries
+from ._time_entries import get_latest_entries

V2/time_tracker/time_entries/_application/_time_entries/__init__.py

@@ -1,3 +1,2 @@
 # flake8: noqa
-from ._delete_time_entry import delete_time_entry
 from ._get_latest_entries import get_latest_entries

V2/time_tracker/time_entries/_application/_time_entries/_delete_time_entry.py

@@ -15,11 +15,21 @@ def get_latest_entries(req: func.HttpRequest) -> func.HttpResponse:
     use_case = _domain._use_cases.GetLastTimeEntryUseCase(time_entry_service)
 
     try:
-        time_entries = use_case.get_latest_entries()
+        owner_id = req.params.get("owner_id")
+        limit = req.params.get("limit")
+
+        if not owner_id:
+            return func.HttpResponse(
+                body="No owner id found",
+                status_code=404,
+                mimetype="application/json"
+            )
+
+        time_entries = use_case.get_latest_entries(int(owner_id), int(limit) if limit and int(limit) > 0 else None)
 
         if not time_entries or len(time_entries) == 0:
             return func.HttpResponse(
-                body="Not found",
+                body="No time entries found",
                 status_code=404,
                 mimetype="application/json"
             )