test: TT-404 fix get all time entries test

Author: Jobzi

V2/tests/api/azure/time_entry_azure_endpoints_test.py

@@ -42,32 +42,28 @@ def test__time_entry_azure_endpoint__creates_an_time_entry__when_time_entry_has_
 
 
 def test__time_entry_azure_endpoint__returns_all_time_entries(
-     create_fake_database, time_entry_factory, insert_time_entry, activity_factory, insert_activity
+     test_db, time_entry_factory, insert_time_entry, activity_factory, insert_activity
 ):
-    fake_database = create_fake_database
-    inserted_activity = insert_activity(activity_factory(), fake_database)
+    inserted_activity = insert_activity(activity_factory(), test_db)
     existent_time_entries = time_entry_factory(activity_id=inserted_activity.id, technologies="[jira,sql]")
-    inserted_time_entries = [insert_time_entry(existent_time_entries, fake_database)]
+    inserted_time_entries = insert_time_entry(existent_time_entries, test_db)
 
-    azure_time_entries._get_time_entries.DATABASE = fake_database
     req = func.HttpRequest(method="GET", body=None, url=TIME_ENTRY_URL)
 
     response = azure_time_entries.get_time_entries(req)
     time_entries_json_data = response.get_body().decode("utf-8")
+    time_entry_list = json.loads(time_entries_json_data)
 
     assert response.status_code == 200
-    assert time_entries_json_data == json.dumps(inserted_time_entries)
+    assert time_entry_list.pop() == inserted_time_entries
 
 
 def test__time_entry_azure_endpoint__returns_an_time_entry__when_time_entry_matches_its_id(
-     create_fake_database, time_entry_factory, insert_time_entry, activity_factory, insert_activity
+     test_db, time_entry_factory, insert_time_entry, activity_factory, insert_activity
 ):
-    fake_database = create_fake_database
-    inserted_activity = insert_activity(activity_factory(), fake_database)
+    inserted_activity = insert_activity(activity_factory(), test_db)
     existent_time_entries = time_entry_factory(activity_id=inserted_activity.id, technologies="[jira,sql]")
-    inserted_time_entries = insert_time_entry(existent_time_entries, fake_database)
-
-    azure_time_entries._get_time_entries.DATABASE = fake_database
+    inserted_time_entries = insert_time_entry(existent_time_entries, test_db)
 
     req = func.HttpRequest(
         method="GET",
@@ -84,14 +80,12 @@ def test__time_entry_azure_endpoint__returns_an_time_entry__when_time_entry_matc
 
 
 def test__get_time_entries_azure_endpoint__returns_a_status_code_400__when_time_entry_recive_invalid_id(
-    create_fake_database, time_entry_factory, insert_time_entry, activity_factory, insert_activity
+    test_db, time_entry_factory, insert_time_entry, activity_factory, insert_activity
 ):
-    fake_database = create_fake_database
-    inserted_activity = insert_activity(activity_factory(), fake_database)
+    inserted_activity = insert_activity(activity_factory(), test_db)
     existent_time_entries = time_entry_factory(activity_id=inserted_activity.id, technologies="[jira,sql]")
-    insert_time_entry(existent_time_entries, fake_database)
+    insert_time_entry(existent_time_entries, test_db)
 
-    azure_time_entries._get_time_entries.DATABASE = fake_database
     req = func.HttpRequest(
         method="GET",
         body=None,

V2/time_tracker/time_entries/_application/_time_entries/_get_time_entries.py

@@ -5,8 +5,6 @@
 import azure.functions as func
 import json
 
-DATABASE = DB()
-
 
 def get_time_entries(req: func.HttpRequest) -> func.HttpResponse:
 
@@ -30,17 +28,19 @@ def get_time_entries(req: func.HttpRequest) -> func.HttpResponse:
 
 
 def _get_by_id(id: int) -> str:
+    database = DB()
     time_entry_use_case = _use_cases.GetTimeEntryUseCase(
-        _create_time_entry_service(DATABASE)
+        _create_time_entry_service(database)
     )
     time_entry = time_entry_use_case.get_time_entry_by_id(id)
 
     return json.dumps(time_entry.__dict__) if time_entry else b'Not Found'
 
 
 def _get_all() -> str:
+    database = DB()
     time_entries_use_case = _use_cases.GetTimeEntriesUseCase(
-        _create_time_entry_service(DATABASE)
+        _create_time_entry_service(database)
     )
     return json.dumps(
         [