fix: TT-418 code smell resolved

mandres2015 · mandres2015 · commit 4e51c432676e · 2021-11-26T10:21:27.000-05:00
diff --git a/V2/tests/integration/daos/customers_dao_test.py b/V2/tests/integration/daos/customers_dao_test.py
@@ -128,7 +128,7 @@ def test__update_customer_dao__returns_an_updated_customer_dto__when_updates_cor
     assert updated_customer.__dict__ == inserted_customer
 
 
-def test__update_customer_dao__returns_None__when_an_incorrect_id_is_passed(
+def test__update_customer_dao__returns_none__when_an_incorrect_id_is_passed(
     test_db, customer_factory, create_fake_dao, insert_customer
 ):
     dao = create_fake_dao(test_db)
diff --git a/V2/time_tracker/customers/_application/_customers/_create_customer.py b/V2/time_tracker/customers/_application/_customers/_create_customer.py
@@ -51,6 +51,6 @@ def create_customer(req: func.HttpRequest) -> func.HttpResponse:
         )
 
 
-def _validate_customer(customer_data: dict) -> bool:
+def _validate_customer(customer_data: dict) -> typing.List[str]:
     return [field.name for field in dataclasses.fields(_domain.Customer)
             if (field.name not in customer_data) and (field.type != typing.Optional[field.type])]

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,6 @@ def create_customer(req: func.HttpRequest) -> func.HttpResponse:`
`51`	`51`	`)`
`52`	`52`
`53`	`53`
`54`		`-def _validate_customer(customer_data: dict) -> bool:`
	`54`	`+def _validate_customer(customer_data: dict) -> typing.List[str]:`
`55`	`55`	`return [field.name for field in dataclasses.fields(_domain.Customer)`
`56`	`56`	`if (field.name not in customer_data) and (field.type != typing.Optional[field.type])]`