Skip to content

Commit 4bc146a

Browse files
committed
fix: TT-403 remove method POST
1 parent 21ff57c commit 4bc146a

File tree

10 files changed

+6
-45
lines changed

10 files changed

+6
-45
lines changed

V2/serverless.yml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -77,16 +77,6 @@ functions:
7777
route: activities/
7878
authLevel: anonymous
7979

80-
create_time_entry:
81-
handler: time_tracker/time_entries/interface.create_time_entry
82-
events:
83-
- http: true
84-
x-azure-settings:
85-
methods:
86-
- POST
87-
route: time-entries/
88-
authLevel: anonymous
89-
9080
delete_time_entry:
9181
handler: time_tracker/time_entries/interface.delete_time_entry
9282
events:

V2/tests/integration/daos/time_entries_dao.test.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,6 @@ def _creator(time_entries):
1818
return _creator
1919

2020

21-
def test_create_time_entry__returns_an_time_entry_dto__when_create_an_time_entry_that_matches_attributes(
22-
create_fake_time_entries, time_entry_factory
23-
):
24-
create_fake_time_entries([])
25-
26-
time_entries_json_dao = TimeEntriesJsonDao(Faker().file_path())
27-
time_entry_data = time_entry_factory()
28-
result = time_entries_json_dao.create(time_entry_data.__dict__)
29-
assert result == TimeEntry(**time_entry_data)
30-
31-
3221
def test_delete__returns_an_time_entry_with_true_deleted__when_an_time_entry_matching_its_id_is_found(
3322
create_fake_time_entries, time_entry_factory
3423
):

V2/tests/unit/use_cases/time_entries_use_case_test.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,6 @@
44
from time_tracker.time_entries._domain import _use_cases
55

66

7-
def test__create_time_entry_function__uses_the_time_entries_service__to_create_time_entry(
8-
mocker: MockFixture, time_entry_factory
9-
):
10-
expected_time_entry = mocker.Mock()
11-
time_entry_service = mocker.Mock(
12-
create=mocker.Mock(return_value=expected_time_entry)
13-
)
14-
15-
time_entry_use_case = _use_cases.CreateTimeEntryUseCase(time_entry_service)
16-
actual_time_entry = time_entry_use_case.create_time_entry(time_entry_factory())
17-
18-
assert time_entry_service.create.called
19-
assert expected_time_entry == actual_time_entry
20-
21-
227
def test__delete_time_entry_function__uses_the_time_entry_service__to_change_time_entry_deleted(
238
mocker: MockFixture,
249
):
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
# flake8: noqa
2-
from ._time_entries import create_time_entry
32
from ._time_entries import delete_time_entry
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
# flake8: noqa
2-
from ._create_time_entry import create_time_entry
32
from ._delete_time_entry import delete_time_entry

V2/time_tracker/time_entries/_application/_time_entries/_create_time_entry.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,15 @@
66

77
from ... import _domain
88
from ... import _infrastructure
9-
from time_tracker._infrastructure import DB
109

10+
_JSON_PATH = (
11+
'time_tracker/time_entries/_infrastructure/_data_persistence/time_entries_data.json'
12+
)
1113

1214

1315
def create_time_entry(req: func.HttpRequest) -> func.HttpResponse:
14-
database = DB()
15-
time_entry_dao = _infrastructure.TimeEntriesSQLDao(database)
16+
17+
time_entry_dao = _infrastructure.TimeEntriesJsonDao(_JSON_PATH)
1618
time_entry_service = _domain.TimeEntryService(time_entry_dao)
1719
use_case = _domain._use_cases.CreateTimeEntryUseCase(time_entry_service)
1820

V2/time_tracker/time_entries/_domain/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,5 @@
33
from ._persistence_contracts import TimeEntriesDao
44
from ._services import TimeEntryService
55
from ._use_cases import (
6-
CreateTimeEntryUseCase,
76
DeleteTimeEntryUseCase
87
)
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
# flake8: noqa
2-
from ._create_time_entry_use_case import CreateTimeEntryUseCase
32
from ._delete_time_entry_use_case import DeleteTimeEntryUseCase

V2/time_tracker/time_entries/_domain/_use_cases/_create_time_entry_use_case.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@ def __init__(self, time_entry_service: TimeEntryService):
77
self.time_entry_service = time_entry_service
88

99
def create_time_entry(self, time_entry_data: TimeEntry) -> TimeEntry:
10-
return self.time_entry_service.create(time_entry_data)
10+
return self.time_entry_service.create(time_entry_data.__dict__)
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
# flake8: noqa
2-
from ._application import create_time_entry
32
from ._application import delete_time_entry

0 commit comments

Comments
 (0)