Skip to content

Commit 406e7f4

Browse files
committed
fix: TT-402 Resolve comments
1 parent a60b3eb commit 406e7f4

File tree

3 files changed

+22
-6
lines changed

3 files changed

+22
-6
lines changed

V2/tests/api/azure/time_entry_azure_endpoints_test.py

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def test__delete_time_entries_azure_endpoint__returns_a_status_code_400__when_ti
7979
assert response.get_body() == b'Invalid Format ID'
8080

8181

82-
def test__update_activity_azure_endpoint__returns_an_activity__when_found_an_activity_to_update(
82+
def test__update_time_entry_azure_endpoint__returns_an_time_entry__when_found_an_time_entry_to_update(
8383
test_db, time_entry_factory, insert_time_entry, activity_factory, insert_activity
8484
):
8585
inserted_activity = insert_activity(activity_factory(), test_db)
@@ -103,7 +103,7 @@ def test__update_activity_azure_endpoint__returns_an_activity__when_found_an_act
103103
assert activitiy_json_data == json.dumps(inserted_time_entries)
104104

105105

106-
def test__update_time_entries_azure_endpoint__returns_a_status_code_400__when_time_entry_recive_invalid_id():
106+
def test__update_time_entries_azure_endpoint__returns_a_status_code_404__when_time_entry_recive_invalid_id():
107107
time_entry_body = {"description": Faker().sentence()}
108108

109109
req = func.HttpRequest(
@@ -115,5 +115,21 @@ def test__update_time_entries_azure_endpoint__returns_a_status_code_400__when_ti
115115

116116
response = azure_time_entries._update_time_entry.update_time_entry(req)
117117

118+
assert response.status_code == 404
119+
assert response.get_body() == b'Invalid Format ID'
120+
121+
122+
def test__update_time_entries_azure_endpoint__returns_a_status_code_400__when_time_entry_recive_invalid_body():
123+
124+
time_entry_body = Faker().pydict(5, True, str)
125+
req = func.HttpRequest(
126+
method="PUT",
127+
body=json.dumps(time_entry_body).encode("utf-8"),
128+
url=TIME_ENTRY_URL,
129+
route_params={"id": Faker().pyint()},
130+
)
131+
132+
response = azure_time_entries._update_time_entry.update_time_entry(req)
133+
118134
assert response.status_code == 400
119-
assert response.get_body() == b'Invalid ID'
135+
assert response.get_body() == b'Incorrect time entry body'

V2/time_tracker/time_entries/_application/_time_entries/_update_time_entry.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ def update_time_entry(req: func.HttpRequest) -> func.HttpResponse:
2222
response = _update(int(time_entry_id), time_entry_data)
2323
status_code = 200
2424
except ValueError:
25-
response = b'Invalid ID'
26-
status_code = 400
25+
response = b'Invalid Format ID'
26+
status_code = 404
2727
else:
2828
response = b'Incorrect time entry body'
2929
status_code = 400

V2/time_tracker/time_entries/_domain/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55
from ._use_cases import (
66
CreateTimeEntryUseCase,
77
DeleteTimeEntryUseCase,
8-
UpdateTimeEntryUseCase
8+
UpdateTimeEntryUseCase,
99
)

0 commit comments

Comments
 (0)