fix: TT-401 changed test db storage

Author: ararcos

V2/tests/api/azure/activity_azure_endpoints_test.py

@@ -11,14 +11,14 @@
 def test__activity_azure_endpoint__returns_all_activities(
     test_db, activity_factory, insert_activity
 ):
-    fake_database = test_db
     existent_activities = [activity_factory(), activity_factory()]
     inserted_activities = [
-        insert_activity(existent_activities[0], fake_database).__dict__,
-        insert_activity(existent_activities[1], fake_database).__dict__
+        insert_activity(existent_activities[0], test_db).__dict__,
+        insert_activity(existent_activities[1], test_db).__dict__
     ]
 
-    azure_activities._get_activities.DATABASE = fake_database
+    azure_activities._get_activities.DATABASE = test_db
+
     req = func.HttpRequest(method='GET', body=None, url=ACTIVITY_URL)
     response = azure_activities._get_activities.get_activities(req)
     activities_json_data = response.get_body().decode("utf-8")
@@ -30,11 +30,10 @@ def test__activity_azure_endpoint__returns_all_activities(
 def test__activity_azure_endpoint__returns_an_activity__when_activity_matches_its_id(
     test_db, activity_factory, insert_activity
 ):
-    fake_database = test_db
     existent_activity = activity_factory()
-    inserted_activity = insert_activity(existent_activity, fake_database).__dict__
+    inserted_activity = insert_activity(existent_activity, test_db).__dict__
 
-    azure_activities._get_activities.DATABASE = fake_database
+    azure_activities._get_activities.DATABASE = test_db
     req = func.HttpRequest(
         method='GET',
         body=None,
@@ -52,11 +51,10 @@ def test__activity_azure_endpoint__returns_an_activity__when_activity_matches_it
 def test__activity_azure_endpoint__returns_an_activity_with_inactive_status__when_an_activity_matching_its_id_is_found(
     test_db, activity_factory, insert_activity
 ):
-    fake_database = test_db
     existent_activity = activity_factory()
-    inserted_activity = insert_activity(existent_activity, fake_database).__dict__
+    inserted_activity = insert_activity(existent_activity, test_db).__dict__
 
-    azure_activities._delete_activity.DATABASE = fake_database
+    azure_activities._delete_activity.DATABASE = test_db
     req = func.HttpRequest(
         method='DELETE',
         body=None,
@@ -75,11 +73,10 @@ def test__activity_azure_endpoint__returns_an_activity_with_inactive_status__whe
 def test__update_activity_azure_endpoint__returns_an_activity__when_found_an_activity_to_update(
     test_db, activity_factory, insert_activity
 ):
-    fake_database = test_db
     existent_activity = activity_factory()
-    inserted_activity = insert_activity(existent_activity, fake_database).__dict__
+    inserted_activity = insert_activity(existent_activity, test_db).__dict__
 
-    azure_activities._update_activity.DATABASE = fake_database
+    azure_activities._update_activity.DATABASE = test_db
     activity_body = {"description": Faker().sentence()}
     req = func.HttpRequest(
         method='PUT',
@@ -96,10 +93,7 @@ def test__update_activity_azure_endpoint__returns_an_activity__when_found_an_act
     assert activitiy_json_data == json.dumps(inserted_activity)
 
 
-def test__activity_azure_endpoint__creates_an_activity__when_activity_has_all_attributes(
-     test_db,
- ):
-    azure_activities._create_activity.DATABASE = test_db
+def test__activity_azure_endpoint__creates_an_activity__when_activity_has_all_attributes():
     activity_body = {
         'id': None,
         'name': Faker().user_name(),

V2/tests/api/azure/time_entry_azure_endpoints_test.py

@@ -10,8 +10,7 @@
 def test__time_entry_azure_endpoint__creates_an_time_entry__when_time_entry_has_all_attributes(
     test_db, time_entry_factory, activity_factory, insert_activity
 ):
-    db = test_db
-    inserted_activity = insert_activity(activity_factory(), db)
+    inserted_activity = insert_activity(activity_factory(), test_db)
     time_entry_body = time_entry_factory(activity_id=inserted_activity.id, technologies="[jira,sql]").__dict__
 
     body = json.dumps(time_entry_body).encode("utf-8")