Skip to content

Commit 0c39250

Browse files
committed
fix: TT-407 enums added in responses
1 parent c7c0966 commit 0c39250

File tree

3 files changed

+14
-12
lines changed

3 files changed

+14
-12
lines changed

V2/serverless.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ functions:
124124
x-azure-settings:
125125
methods:
126126
- GET
127-
route: time-entries/latest
127+
route: time-entries/latest/
128128
authLevel: anonymous
129129

130130
create_customer:

V2/tests/api/azure/time_entry_azure_endpoints_test.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
from time_tracker._infrastructure import DB
1010
from time_tracker.time_entries import _domain as domain_time_entries
1111
from time_tracker.time_entries import _infrastructure as infrastructure_time_entries
12+
from time_tracker.utils.enums import ResponseEnums
1213

1314

1415
TIME_ENTRY_URL = "/api/time-entries/"
@@ -227,11 +228,11 @@ def test__get_latest_entries_azure_endpoint__returns_a_list_of_latest_time_entri
227228
response = azure_time_entries._get_latest_entries.get_latest_entries(req)
228229
time_entry_json_data = json.loads(response.get_body().decode("utf-8"))
229230

230-
assert response.status_code == 200
231+
assert response.status_code == HTTPStatus.OK
231232
assert time_entry_json_data == [inserted_time_entry]
232233

233234

234-
def test__get_latest_entries_azure_endpoint__returns_No_time_entries_found__when_recieve_an_invalid_owner_id(
235+
def test__get_latest_entries_azure_endpoint__returns_not_found__when_recieve_an_invalid_owner_id(
235236
test_db, insert_activity, activity_factory,
236237
):
237238
insert_activity(activity_factory(), test_db)
@@ -245,5 +246,5 @@ def test__get_latest_entries_azure_endpoint__returns_No_time_entries_found__when
245246

246247
response = azure_time_entries._get_latest_entries.get_latest_entries(req)
247248

248-
assert response.status_code == 404
249-
assert response.get_body() == b'No time entries found'
249+
assert response.status_code == HTTPStatus.NOT_FOUND
250+
assert response.get_body().decode("utf-8") == ResponseEnums.NOT_FOUND.value

V2/time_tracker/time_entries/_application/_time_entries/_get_latest_entries.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
from ... import _domain
77
from ... import _infrastructure
88
from time_tracker._infrastructure import DB
9+
from time_tracker.utils.enums import ResponseEnums
910

1011

1112
def get_latest_entries(req: func.HttpRequest) -> func.HttpResponse:
@@ -20,29 +21,29 @@ def get_latest_entries(req: func.HttpRequest) -> func.HttpResponse:
2021

2122
if not owner_id:
2223
return func.HttpResponse(
23-
body="No owner id found",
24+
body=ResponseEnums.NOT_FOUND.value,
2425
status_code=HTTPStatus.NOT_FOUND,
25-
mimetype="application/json"
26+
mimetype=ResponseEnums.MIME_TYPE.value,
2627
)
2728

2829
time_entries = use_case.get_latest_entries(int(owner_id), int(limit) if limit and int(limit) > 0 else None)
2930

3031
if not time_entries or len(time_entries) == 0:
3132
return func.HttpResponse(
32-
body="No time entries found",
33+
body=ResponseEnums.NOT_FOUND.value,
3334
status_code=HTTPStatus.NOT_FOUND,
34-
mimetype="application/json"
35+
mimetype=ResponseEnums.MIME_TYPE.value,
3536
)
3637

3738
return func.HttpResponse(
3839
body=json.dumps(time_entries, default=str),
3940
status_code=HTTPStatus.OK,
40-
mimetype="application/json",
41+
mimetype=ResponseEnums.MIME_TYPE.value,
4142
)
4243

4344
except ValueError:
4445
return func.HttpResponse(
45-
body=b"Invalid Format ID",
46+
body=ResponseEnums.INVALID_ID.value,
4647
status_code=HTTPStatus.BAD_REQUEST,
47-
mimetype="application/json"
48+
mimetype=ResponseEnums.MIME_TYPE.value,
4849
)

0 commit comments

Comments
 (0)