Skip to content

Commit 020585c

Browse files
committed
TT-94 feat: extract role fields as global var
1 parent 63fbec9 commit 020585c

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

utils/azure_users.py

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,14 @@ def __init__(self, id, name, email, role):
5050
'Accept': 'application/json',
5151
}
5252

53+
ROLE_FIELD_VALUES = {
54+
'admin': (
55+
'extension_1d76efa96f604499acc0c0ee116a1453_role',
56+
'time_tracker_admin',
57+
),
58+
'test': ('waitforrealvalue', 'waitforrealvalue'),
59+
}
60+
5361

5462
class AzureConnection:
5563
def __init__(self, config=MSConfig):
@@ -83,7 +91,7 @@ def users(self) -> List[AzureUser]:
8391
assert 'value' in response.json()
8492
return [self.to_azure_user(item) for item in response.json()['value']]
8593

86-
# TODO : DEPRECATE OR UPDATE
94+
# TODO : DEPRECATE
8795
def update_user_role(self, id, role):
8896
endpoint = "{endpoint}/users/{user_id}?api-version=1.6".format(
8997
endpoint=self.config.ENDPOINT, user_id=id
@@ -132,14 +140,7 @@ def update_role(self, user_id, role_id, is_grant):
132140
return self.to_azure_user(response.json())
133141

134142
def get_role_data(self, role_id, is_grant=True):
135-
ROLE_VALUES = {
136-
'admin': (
137-
'extension_1d76efa96f604499acc0c0ee116a1453_role',
138-
'time_tracker_admin',
139-
),
140-
'test': ('waitforrealvalue', 'waitforrealvalue'),
141-
}
142-
field_name, field_value = ROLE_VALUES[role_id]
143+
field_name, field_value = ROLE_FIELD_VALUES[role_id]
143144
if is_grant:
144145
return {field_name: field_value}
145146
else:

0 commit comments

Comments
 (0)