refactor: TT-198 Remove public notifications in the channel slack: #ioet-time-tracker (#45)

Author: LEON12699

AutomaticClockOuts/clock_out.js

@@ -24,26 +24,21 @@ const doClockOut = async (context) => {
   context.log(`Checking for time-entries that need to be clocked out`);
 
   let totalClockOutsExecuted = 0;
-  const usersWithClockOut = [];
 
   await Promise.all(entries.map(async (timeEntryAsJson) => {
     const timeEntry = new TimeEntry(timeEntryAsJson)
     if (timeEntry.needsToBeClockedOut()) {
       const user_email = findUserEmail(users, timeEntry.timeEntry.owner_id);
       const userId = findSlackUserId(slackUsers, user_email);
       if(userId){
-        usersWithClockOut.push("<@"+userId+">");
         SlackClient.sendMessageToUser(userId, CLOCK_OUT_MESSAGE);
       }
       timeEntryAsJson.end_date = timeEntry.getTimeToClockOut()
       await container.item(timeEntryAsJson.id, timeEntryAsJson.tenant_id).replace(timeEntryAsJson)
       totalClockOutsExecuted++
     }
   }));
-  if (usersWithClockOut.length) {
-    const ClockOutMessageChannel=`${CLOCK_OUT_MESSAGE} \n- ${usersWithClockOut.join('\n- ')}`;
-    SlackClient.sendMessageToChannel(ClockOutMessageChannel);
-  }
+  
   context.log(`I just clocked out ${totalClockOutsExecuted} entries, thanks are not needed...`);
 }
 
@@ -57,6 +52,4 @@ const findSlackUserId = (users, email) => {
   return user ? user.id : null
 }
 
-doClockOut(console)
-
 module.exports = { doClockOut };

AutomaticClockOuts/config.js

@@ -6,8 +6,7 @@ const config = {
     clientId: process.env["CLIENT_ID"],
     authority: process.env["AUTHORITY"],
     clientSecret: process.env["CLIENT_SECRET"],
-    slackApiToken: process.env["SLACK_TOKEN_NOTIFY"],
-    channelId: process.env["ID_CHANNEL_NOTIFY"]
+    slackApiToken: process.env["SLACK_TOKEN_NOTIFY"]
 };
 
 module.exports = config;

AutomaticClockOuts/readme.md

@@ -38,6 +38,5 @@ CLIENT_ID='XXX'
 AUTHORITY='XXX'
 CLIENT_SECRET='XXX'
 SLACK_TOKEN_NOTIFY='XXX'
-ID_CHANNEL_NOTIFY='XXX'
-``` 
+```
 Check the pinned message in our slack channel to get these values

AutomaticClockOuts/slack_client.js

@@ -1,5 +1,5 @@
 const { WebClient, LogLevel } = require("@slack/web-api");
-const { slackApiToken, channelId } = require("./config");
+const { slackApiToken } = require("./config");
 const client = new WebClient(slackApiToken, { logLevel: LogLevel.DEBUG });
 
 const findUsersInSlack = async () => {
@@ -23,9 +23,4 @@ const sendMessageToUser = (userId, message) => {
   sendMessage(userId, message);
 };
 
-// message to public channel
-const sendMessageToChannel = (message) => {
-  sendMessage(channelId, message);
-};
-
-module.exports = { findUsersInSlack, sendMessageToUser, sendMessageToChannel };
+module.exports = { findUsersInSlack, sendMessageToUser };

nodejs-functions/src/handlers/automatic-clock-outs/clock_out.js

@@ -24,26 +24,21 @@ const doClockOut = async (context) => {
   context.log(`Checking for time-entries that need to be clocked out`);
 
   let totalClockOutsExecuted = 0;
-  const usersWithClockOut = [];
 
   await Promise.all(entries.map(async (timeEntryAsJson) => {
     const timeEntry = new TimeEntry(timeEntryAsJson)
     if (timeEntry.needsToBeClockedOut()) {
       const user_email = findUserEmail(users, timeEntry.timeEntry.owner_id);
       const userId = findSlackUserId(slackUsers, user_email);
       if(userId){
-        usersWithClockOut.push("<@"+userId+">");
         SlackClient.sendMessageToUser(userId, CLOCK_OUT_MESSAGE);
       }
       timeEntryAsJson.end_date = timeEntry.getTimeToClockOut()
       await container.item(timeEntryAsJson.id, timeEntryAsJson.tenant_id).replace(timeEntryAsJson)
       totalClockOutsExecuted++
     }
   }));
-  if (usersWithClockOut.length) {
-    const ClockOutMessageChannel=`${CLOCK_OUT_MESSAGE} \n- ${usersWithClockOut.join('\n- ')}`;
-    SlackClient.sendMessageToChannel(ClockOutMessageChannel);
-  }
+  
   context.log(`I just clocked out ${totalClockOutsExecuted} entries, thanks are not needed...`);
 }
 

nodejs-functions/src/handlers/automatic-clock-outs/config.js

@@ -6,8 +6,7 @@ const config = {
     clientId: process.env["CLIENT_ID"],
     authority: process.env["AUTHORITY"],
     clientSecret: process.env["CLIENT_SECRET"],
-    slackApiToken: process.env["SLACK_TOKEN_NOTIFY"],
-    channelId: process.env["ID_CHANNEL_NOTIFY"]
+    slackApiToken: process.env["SLACK_TOKEN_NOTIFY"]
 };
 
 module.exports = config;

nodejs-functions/src/handlers/automatic-clock-outs/readme.md

@@ -38,6 +38,5 @@ CLIENT_ID='XXX'
 AUTHORITY='XXX'
 CLIENT_SECRET='XXX'
 SLACK_TOKEN_NOTIFY='XXX'
-ID_CHANNEL_NOTIFY='XXX'
-``` 
+```
 Check the pinned message in our slack channel to get these values

nodejs-functions/src/handlers/automatic-clock-outs/slack_client.js

@@ -1,5 +1,5 @@
 const { WebClient, LogLevel } = require("@slack/web-api");
-const { slackApiToken, channelId } = require("./config");
+const { slackApiToken } = require("./config");
 const client = new WebClient(slackApiToken, { logLevel: LogLevel.DEBUG });
 
 const findUsersInSlack = async () => {
@@ -23,9 +23,4 @@ const sendMessageToUser = (userId, message) => {
   sendMessage(userId, message);
 };
 
-// message to public channel
-const sendMessageToChannel = (message) => {
-  sendMessage(channelId, message);
-};
-
-module.exports = { findUsersInSlack, sendMessageToUser, sendMessageToChannel };
+module.exports = { findUsersInSlack, sendMessageToUser };