refactor: Refactor of code smells

Author: cxcarvaj

nodejs-functions/src/handlers/automatic-clock-outs/clock_out.js

@@ -8,9 +8,7 @@ const SlackClient = require('./slack_client');
 const { CLOCK_OUT_MESSAGE, CLOCK_OUT_MESSAGE_MIDNIGHT } = require('./constants');
 
 const doClockOut = async (context) => {
-  context.log(
-    `I am going to check how many entries were not clocked out ${new Date()}`
-  );
+  context.log(`I am going to check how many entries were not clocked out ${new Date()}`);
 
   const { endpoint, key, databaseId } = config;
   const client = new CosmosClient({ endpoint, key });
@@ -52,21 +50,17 @@ const doClockOut = async (context) => {
     })
   );
 
-  context.log(
-    `I just clocked out ${totalClockOutsExecuted} entries, thanks are not needed...`
-  );
+  context.log(`I just clocked out ${totalClockOutsExecuted} entries, thanks are not needed...`);
 };
 
 const findUserData = (users, id) => {
-  const user = users.find((user) => user.id === id);
-  return user
-    ? { userName: user.name.split(' ')[0], userEmail: user.email }
-    : {};
+  const targetUser = users.find((user) => user.id === id);
+  return targetUser ? { userName: targetUser.name.split(' ')[0], userEmail: targetUser.email } : {};
 };
 
 const findSlackUserId = (slackUsers, email) => {
-  const user = slackUsers.find((slackUser) => slackUser.email === email);
-  return user ? user.id : null;
+  const slackTargetUser = slackUsers.find((slackUser) => slackUser.email === email);
+  return slackTargetUser ? slackTargetUser.id : null;
 };
 
 module.exports = { doClockOut };

nodejs-functions/src/handlers/automatic-clock-outs/msal_client.js

@@ -21,8 +21,7 @@ const getToken = async () => {
     },
   };
 
-  return await axios
-    .post(endpoint, params, headers)
+  return axios.post(endpoint, params, headers)
     .then((result) => {
       return result.data.access_token;
     })
@@ -41,7 +40,7 @@ const findUsersInMS = async () => {
     },
   };
 
-  return await axios.get(`${endpoint}/users`, headers);
+  return axios.get(`${endpoint}/users`, headers);
 };
 
 module.exports = { findUsersInMS };