From a6377997953ced70c78c8c3a3a33ee17a31dc8f3 Mon Sep 17 00:00:00 2001 From: Rich Salz Date: Fri, 15 Mar 2024 22:44:44 -0400 Subject: [PATCH 01/23] feat: More clarity in nomcom feedback, and ... (#7191) * feat: Remove trailing period from photo title, etc For consistency, in email and photo tooltips, remove the trailing period. * feat: Remove email link in NomCom feedback Seeing "User Name {envelope}" seems to confuse people; it's two links, not one. So don't show the envelope-icon, Also change text to say "current nomcom" when saying who gets it. Fixes: #7032 --- ietf/templates/nomcom/feedback.html | 6 +++--- ietf/templates/person/person_link.html | 6 +++--- ietf/templates/person/photo.html | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/ietf/templates/nomcom/feedback.html b/ietf/templates/nomcom/feedback.html index effacdf67a..8c9e8c824f 100644 --- a/ietf/templates/nomcom/feedback.html +++ b/ietf/templates/nomcom/feedback.html @@ -81,7 +81,7 @@

- Provide feedback about {% person_link form.nominee.person %} + Provide feedback about {% person_link form.nominee.person with_email=False %} for the {{ form.position.name }} position.

{% elif form.topic %} @@ -97,8 +97,8 @@

{% endif %}

This feedback will only be available to - NomCom {{ year }}. - You may have the feedback mailed back to you by selecting the option below. + the current NomCom. + You can have the feedback mailed back to you by selecting the option below.

{% csrf_token %} diff --git a/ietf/templates/person/person_link.html b/ietf/templates/person/person_link.html index 74ab43b945..f3f7e1a5b7 100644 --- a/ietf/templates/person/person_link.html +++ b/ietf/templates/person/person_link.html @@ -1,8 +1,8 @@ {% if email and email == "system@datatracker.ietf.org" or name and name == "(System)" %}(System){% else %}{% if email or name %}{{ name }}{% if email and with_email %} + aria-label="Compose email to {{ email }}" + title="Compose email to {{ email }}"> {% endif %}{% else %}(None){% endif %}{% endif %} \ No newline at end of file diff --git a/ietf/templates/person/photo.html b/ietf/templates/person/photo.html index 4cea8ccb1f..62c1ed991c 100644 --- a/ietf/templates/person/photo.html +++ b/ietf/templates/person/photo.html @@ -2,7 +2,7 @@ {% load origin static person_filters %}
{% if name or email %} - {% endif %} {% if person.photo_thumb %} From b21706ef5c5498a9f382a5041554664cd8f4c4ee Mon Sep 17 00:00:00 2001 From: Rich Salz Date: Sat, 16 Mar 2024 00:13:09 -0400 Subject: [PATCH 02/23] fix: Fix typo (#7193) Fixes: #6962 --- ietf/secr/templates/includes/activities.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ietf/secr/templates/includes/activities.html b/ietf/secr/templates/includes/activities.html index 3e79c9aed4..1304b7c48d 100644 --- a/ietf/secr/templates/includes/activities.html +++ b/ietf/secr/templates/includes/activities.html @@ -1,4 +1,4 @@ -

Activies Log

+

Activities Log