From 1a9583bf2e040220021fd98078c838e3cf07e3ea Mon Sep 17 00:00:00 2001 From: Rich Salz Date: Fri, 15 Mar 2024 21:47:03 -0400 Subject: [PATCH 1/2] feat: Remove trailing period from photo title, etc For consistency, in email and photo tooltips, remove the trailing period. --- ietf/templates/person/person_link.html | 6 +++--- ietf/templates/person/photo.html | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ietf/templates/person/person_link.html b/ietf/templates/person/person_link.html index 74ab43b9451..f3f7e1a5b7a 100644 --- a/ietf/templates/person/person_link.html +++ b/ietf/templates/person/person_link.html @@ -1,8 +1,8 @@ {% if email and email == "system@datatracker.ietf.org" or name and name == "(System)" %}(System){% else %}{% if email or name %}{{ name }}{% if email and with_email %} + aria-label="Compose email to {{ email }}" + title="Compose email to {{ email }}"> {% endif %}{% else %}(None){% endif %}{% endif %} \ No newline at end of file diff --git a/ietf/templates/person/photo.html b/ietf/templates/person/photo.html index 4cea8ccb1fc..62c1ed991c3 100644 --- a/ietf/templates/person/photo.html +++ b/ietf/templates/person/photo.html @@ -2,7 +2,7 @@ {% load origin static person_filters %}
{% if name or email %} - {% endif %} {% if person.photo_thumb %} From df686bfc362e05b6f232879ab1378acb1afbbb8e Mon Sep 17 00:00:00 2001 From: Rich Salz Date: Fri, 15 Mar 2024 21:48:22 -0400 Subject: [PATCH 2/2] feat: Remove email link in NomCom feedback Seeing "User Name {envelope}" seems to confuse people; it's two links, not one. So don't show the envelope-icon, Also change text to say "current nomcom" when saying who gets it. Fixes: #7032 --- ietf/templates/nomcom/feedback.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ietf/templates/nomcom/feedback.html b/ietf/templates/nomcom/feedback.html index effacdf67a2..8c9e8c824f9 100644 --- a/ietf/templates/nomcom/feedback.html +++ b/ietf/templates/nomcom/feedback.html @@ -81,7 +81,7 @@

- Provide feedback about {% person_link form.nominee.person %} + Provide feedback about {% person_link form.nominee.person with_email=False %} for the {{ form.position.name }} position.

{% elif form.topic %} @@ -97,8 +97,8 @@

{% endif %}

This feedback will only be available to - NomCom {{ year }}. - You may have the feedback mailed back to you by selecting the option below. + the current NomCom. + You can have the feedback mailed back to you by selecting the option below.

{% csrf_token %}