From 3a159eadf198a64cb826e54fa9861ecf920dc0f3 Mon Sep 17 00:00:00 2001 From: Jennifer Richards Date: Thu, 29 Feb 2024 12:56:00 -0400 Subject: [PATCH 1/3] test: Tweak test to avoid Leap Day failure MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 🎉 --- ietf/submit/tests.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ietf/submit/tests.py b/ietf/submit/tests.py index 9871023e46..900a8e79c0 100644 --- a/ietf/submit/tests.py +++ b/ietf/submit/tests.py @@ -3669,7 +3669,10 @@ def test_api_submit_no_title(self): self.assertContains(r, expected, status_code=400) def test_api_submit_failed_idnits(self): - r, author, name = self.do_post_submission('00', year="2010") + # year needs to be a leap year or this test will fail on Feb 29... + r, author, name = self.do_post_submission('00', year="2012") + with open("submit_failed_idnits_output.txt", "wb") as f: + f.write(r.content) expected = "Document date must be within 3 days of submission date" self.assertContains(r, expected, status_code=400) From 6f6ff8ac0483f586c6f5d616c9f227063fc6f96e Mon Sep 17 00:00:00 2001 From: Jennifer Richards Date: Thu, 29 Feb 2024 13:08:18 -0400 Subject: [PATCH 2/3] chore: Rephrase comment --- ietf/submit/tests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ietf/submit/tests.py b/ietf/submit/tests.py index 900a8e79c0..2b62a2109d 100644 --- a/ietf/submit/tests.py +++ b/ietf/submit/tests.py @@ -3669,7 +3669,7 @@ def test_api_submit_no_title(self): self.assertContains(r, expected, status_code=400) def test_api_submit_failed_idnits(self): - # year needs to be a leap year or this test will fail on Feb 29... + # `year` on the next line must be leap year or this test will fail every Feb 29 r, author, name = self.do_post_submission('00', year="2012") with open("submit_failed_idnits_output.txt", "wb") as f: f.write(r.content) From 4836e73155b0698c700643077789aaf831e14710 Mon Sep 17 00:00:00 2001 From: Jennifer Richards Date: Thu, 29 Feb 2024 13:20:46 -0400 Subject: [PATCH 3/3] chore: Remove debug code --- ietf/submit/tests.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/ietf/submit/tests.py b/ietf/submit/tests.py index 2b62a2109d..1e432cb8ef 100644 --- a/ietf/submit/tests.py +++ b/ietf/submit/tests.py @@ -3671,8 +3671,6 @@ def test_api_submit_no_title(self): def test_api_submit_failed_idnits(self): # `year` on the next line must be leap year or this test will fail every Feb 29 r, author, name = self.do_post_submission('00', year="2012") - with open("submit_failed_idnits_output.txt", "wb") as f: - f.write(r.content) expected = "Document date must be within 3 days of submission date" self.assertContains(r, expected, status_code=400)