From d0afbe5279dd31b891c0ee6f53df89d72c836c1e Mon Sep 17 00:00:00 2001 From: Jennifer Richards Date: Fri, 5 Jan 2024 12:44:40 -0400 Subject: [PATCH 1/3] fix: Use refactored method --- ietf/doc/views_doc.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ietf/doc/views_doc.py b/ietf/doc/views_doc.py index adbd245f99a..e223506687d 100644 --- a/ietf/doc/views_doc.py +++ b/ietf/doc/views_doc.py @@ -287,7 +287,8 @@ def document_main(request, name, rev=None, document_html=False): presentations = doc.future_presentations() - augment_docs_and_user_with_user_info([doc], request.user) + if request.user.is_authenticated: + augment_docs_and_person_with_person_info([doc], request.user.person) exp_comment = doc.latest_event(IanaExpertDocEvent,type="comment") iana_experts_comment = exp_comment and exp_comment.desc From bf042e20bf9810479a2d18290ae5833d899ef8ca Mon Sep 17 00:00:00 2001 From: Jennifer Richards Date: Fri, 5 Jan 2024 12:45:45 -0400 Subject: [PATCH 2/3] fix: Don't assume user has person --- ietf/doc/views_doc.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ietf/doc/views_doc.py b/ietf/doc/views_doc.py index e223506687d..64f9de4f586 100644 --- a/ietf/doc/views_doc.py +++ b/ietf/doc/views_doc.py @@ -287,7 +287,7 @@ def document_main(request, name, rev=None, document_html=False): presentations = doc.future_presentations() - if request.user.is_authenticated: + if request.user.is_authenticated and hasattr(request.user, "person"): augment_docs_and_person_with_person_info([doc], request.user.person) exp_comment = doc.latest_event(IanaExpertDocEvent,type="comment") @@ -581,7 +581,7 @@ def document_main(request, name, rev=None, document_html=False): elif can_edit_stream_info and (iesg_state_slug in ('idexists','watching')): actions.append(("Submit to IESG for Publication", urlreverse('ietf.doc.views_draft.to_iesg', kwargs=dict(name=doc.name)))) - if request.user.is_authenticated: + if request.user.is_authenticated and hasattr(request.user, "person"): augment_docs_and_person_with_person_info([doc], request.user.person) published = doc.latest_event(type="published_rfc") # todo rethink this now that published_rfc is on rfc From a9fe273eff52374e4d4ac60097ea19ad08470a06 Mon Sep 17 00:00:00 2001 From: Jennifer Richards Date: Fri, 5 Jan 2024 13:06:46 -0400 Subject: [PATCH 3/3] fix: Use new view param name --- ietf/templates/doc/document_rfc.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ietf/templates/doc/document_rfc.html b/ietf/templates/doc/document_rfc.html index 36c9babd792..9e889afaff7 100644 --- a/ietf/templates/doc/document_rfc.html +++ b/ietf/templates/doc/document_rfc.html @@ -129,14 +129,14 @@ {% if user.is_authenticated %} Untrack