From 4e0b70af3727c680f0cfeecb0bb1c8fadc5daf6b Mon Sep 17 00:00:00 2001 From: maybe-hello-world Date: Sat, 22 Jul 2023 23:17:31 +0000 Subject: [PATCH 1/3] fix: provide date for revisions in bibtex output --- ietf/doc/views_doc.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ietf/doc/views_doc.py b/ietf/doc/views_doc.py index c87602a9fcc..82495cbef73 100644 --- a/ietf/doc/views_doc.py +++ b/ietf/doc/views_doc.py @@ -1112,6 +1112,9 @@ def document_bibtex(request, name, rev=None): else: doi = None + if doc.is_dochistory() and (latest_event := doc.latest_event(type='new_revision')): + doc.pub_date = latest_event.time + return render(request, "doc/document_bibtex.bib", dict(doc=doc, replaced_by=replaced_by, From d07c09ffb900dec72321dc4dc8436f6c001ea7ed Mon Sep 17 00:00:00 2001 From: maybe-hello-world Date: Sat, 22 Jul 2023 23:54:16 +0000 Subject: [PATCH 2/3] refactor: change walrus to if's --- ietf/doc/views_doc.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ietf/doc/views_doc.py b/ietf/doc/views_doc.py index 82495cbef73..f4310450d3c 100644 --- a/ietf/doc/views_doc.py +++ b/ietf/doc/views_doc.py @@ -1112,8 +1112,10 @@ def document_bibtex(request, name, rev=None): else: doi = None - if doc.is_dochistory() and (latest_event := doc.latest_event(type='new_revision')): - doc.pub_date = latest_event.time + if doc.is_dochistory(): + latest_event = doc.latest_event(type='new_revision') + if latest_event: + doc.pub_date = latest_event.time return render(request, "doc/document_bibtex.bib", dict(doc=doc, From 869189653a0911c8b0918797b997beb125f11fcb Mon Sep 17 00:00:00 2001 From: maybe-hello-world Date: Sun, 23 Jul 2023 04:06:39 +0000 Subject: [PATCH 3/3] fix: specify particular revision for events --- ietf/doc/views_doc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ietf/doc/views_doc.py b/ietf/doc/views_doc.py index f4310450d3c..4051b724a0a 100644 --- a/ietf/doc/views_doc.py +++ b/ietf/doc/views_doc.py @@ -1113,7 +1113,7 @@ def document_bibtex(request, name, rev=None): doi = None if doc.is_dochistory(): - latest_event = doc.latest_event(type='new_revision') + latest_event = doc.latest_event(type='new_revision', rev=rev) if latest_event: doc.pub_date = latest_event.time