From b879ec8a3b21a69597a7e257a1d5b67321916e6c Mon Sep 17 00:00:00 2001 From: Jennifer Richards Date: Thu, 8 Jan 2026 11:24:53 -0400 Subject: [PATCH 1/2] fix: avoid over-return --- ietf/community/utils.py | 10 ++++++++-- ietf/settings.py | 2 +- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/ietf/community/utils.py b/ietf/community/utils.py index 0cde2b23c87..b6137095ef5 100644 --- a/ietf/community/utils.py +++ b/ietf/community/utils.py @@ -124,10 +124,16 @@ def community_list_rules_matching_doc(doc): # author rules if doc.type_id == "rfc": - # this will over-return but will be least likely to surprise + has_rfcauthors = doc.rfcauthor_set.exists() rules |= SearchRule.objects.filter( rule_type="author_rfc", - person__in=list(Person.objects.filter(Q(documentauthor__document=doc)|Q(rfcauthor__document=doc))), + person__in=list( + Person.objects.filter( + Q(rfcauthor__document=doc) + if has_rfcauthors + else Q(documentauthor__document=doc) + ) + ), ) else: rules |= SearchRule.objects.filter( diff --git a/ietf/settings.py b/ietf/settings.py index 8932de938a1..c274fba6d2d 100644 --- a/ietf/settings.py +++ b/ietf/settings.py @@ -452,6 +452,7 @@ def skip_unreadable_post(record): "django.contrib.sessions.middleware.SessionMiddleware", "django.contrib.auth.middleware.AuthenticationMiddleware", "django.contrib.messages.middleware.MessageMiddleware", + "ietf.middleware.is_authenticated_header_middleware", "django.middleware.http.ConditionalGetMiddleware", "simple_history.middleware.HistoryRequestMiddleware", # comment in this to get logging of SQL insert and update statements: @@ -462,7 +463,6 @@ def skip_unreadable_post(record): "django.middleware.clickjacking.XFrameOptionsMiddleware", "django.middleware.security.SecurityMiddleware", "ietf.middleware.unicode_nfkc_normalization_middleware", - "ietf.middleware.is_authenticated_header_middleware", ] ROOT_URLCONF = 'ietf.urls' From 17a8b51eb4170b230171ce2e8242c1f196395c99 Mon Sep 17 00:00:00 2001 From: Jennifer Richards Date: Fri, 9 Jan 2026 16:16:02 -0400 Subject: [PATCH 2/2] chore: undo accidental commit This is a separate bug fix on main; let it come in from there. --- ietf/settings.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ietf/settings.py b/ietf/settings.py index c274fba6d2d..8932de938a1 100644 --- a/ietf/settings.py +++ b/ietf/settings.py @@ -452,7 +452,6 @@ def skip_unreadable_post(record): "django.contrib.sessions.middleware.SessionMiddleware", "django.contrib.auth.middleware.AuthenticationMiddleware", "django.contrib.messages.middleware.MessageMiddleware", - "ietf.middleware.is_authenticated_header_middleware", "django.middleware.http.ConditionalGetMiddleware", "simple_history.middleware.HistoryRequestMiddleware", # comment in this to get logging of SQL insert and update statements: @@ -463,6 +462,7 @@ def skip_unreadable_post(record): "django.middleware.clickjacking.XFrameOptionsMiddleware", "django.middleware.security.SecurityMiddleware", "ietf.middleware.unicode_nfkc_normalization_middleware", + "ietf.middleware.is_authenticated_header_middleware", ] ROOT_URLCONF = 'ietf.urls'