Skip to content

Commit fe6c2d6

Browse files
committed
Replace the Http404 in release/views.py if the changelog file is not
found with a simple error message, this mimicks the way the rest of the Datatracker is handling missing files and avoids an annoying 404 when running the test-crawler without all directories set up - Legacy-Id: 7105
1 parent 5dcd140 commit fe6c2d6

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

ietf/release/views.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
from django.template import RequestContext
55
from django.shortcuts import render_to_response
66
from django.conf import settings
7-
from django.http import Http404
7+
from django.http import HttpResponse
88

99
import changelog
1010

@@ -13,14 +13,14 @@ def release(request, version=None):
1313
if os.path.exists(settings.CHANGELOG_PATH):
1414
log_entries = changelog.parse(settings.CHANGELOG_PATH)
1515
else:
16-
raise Http404()
16+
return HttpResponse("Error: changelog file %s not found" % settings.CHANGELOG_PATH)
1717
next = None
1818
for entry in log_entries:
1919
if next:
2020
next.prev = entry
2121
entry.next = next
2222
next = entry
23-
entries = dict([ (entry.version, entry) for entry in log_entries])
23+
entries = dict((entry.version, entry) for entry in log_entries)
2424
if version == None or version not in entries:
2525
version = log_entries[0].version
2626
return render_to_response('release/release.html', { 'releases': log_entries, 'version': version, 'entry': entries[version], }, context_instance=RequestContext(request))

0 commit comments

Comments
 (0)