Don't crash if an attachment has been created already, just reuse it - this case shouldn't actually happen, but apparently sometimes does, probably due to a concurrency issue

 - Legacy-Id: 5797

Author: OleLaursen

ietf/liaisons/formsREDESIGN.py

@@ -280,11 +280,13 @@ def save_attachments(self, instance):
                 extension = ''
             written += 1
             name = instance.name() + ("-attachment-%s" % written)
-            attach = Document.objects.create(
-                title = self.data.get(title_key),
-                type_id = "liaison",
+            attach, _ = Document.objects.get_or_create(
                 name = name,
-                external_url = name + extension, # strictly speaking not necessary, but just for the time being ...
+                defaults=dict(
+                    title = self.data.get(title_key),
+                    type_id = "liaison",
+                    external_url = name + extension, # strictly speaking not necessary, but just for the time being ...
+                    )
                 )
             instance.attachments.add(attach)
             attach_file = open(os.path.join(settings.LIAISON_ATTACH_PATH, attach.name + extension), 'w')