Skip to content

Commit fab9580

Browse files
committed
Merged in [16815] from rjsparks@nostrum.com:
Link to the about pages for groups even if they don't have a charter (some have other forms of descriptive text, and all have more information on the group pages than they did a few years ago). Fixes ietf-tools#2744. - Legacy-Id: 16848 Note: SVN reference [16815] has been migrated to Git commit 26e3e62
1 parent 38a8563 commit fab9580

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

ietf/group/tests_review.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -564,11 +564,11 @@ def test_send_review_reminder_overdue_assignment(self):
564564
self.assertTrue(secretary.person.email_address() in outbox[0]["To"])
565565
self.assertEqual(outbox[0]["Subject"], "1 Overdue review for team {}".format(review_req.team.acronym))
566566
message = outbox[0].get_payload(decode=True).decode("utf-8")
567-
self.assertTrue(review_req.team.acronym + ' has 1 accepted or assigned review overdue by at least 5 days.' in message)
568-
self.assertTrue('Review of {} by {}'.format(review_req.doc.name, reviewer.name) in message)
567+
self.assertIn(review_req.team.acronym + ' has 1 accepted or assigned review overdue by at least 5 days.', message)
568+
self.assertIn('Review of {} by {}'.format(review_req.doc.name, reviewer.plain_name()), message)
569569
self.assertEqual(len(log), 1)
570-
self.assertTrue(secretary.person.email_address() in log[0])
571-
self.assertTrue('1 overdue review' in log[0])
570+
self.assertIn(secretary.person.email_address(), log[0])
571+
self.assertIn('1 overdue review', log[0])
572572

573573
def test_send_reminder_all_open_reviews(self):
574574
review_req = ReviewRequestFactory(state_id='assigned')

ietf/templates/meeting/agenda.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ <h2>
291291
<td><span class="hidden-xs">{{item.session.historic_group.historic_parent.acronym}}</span></td>
292292

293293
<td>
294-
{% if item.session.historic_group.charter %}
294+
{% if item.session.historic_group %}
295295
<a href="{% url 'ietf.group.views.group_about' acronym=item.session.historic_group.acronym %}">{{item.session.historic_group.acronym}}</a>
296296
{% else %}
297297
{{item.session.historic_group.acronym}}

0 commit comments

Comments
 (0)