Skip to content

Commit f9b76bf

Browse files
committed
Made ietf/secr/proceedings pyflakes-clean.
- Legacy-Id: 7492
1 parent c4c8eff commit f9b76bf

8 files changed

Lines changed: 47 additions & 56 deletions

File tree

ietf/secr/proceedings/forms.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
1+
import os
2+
13
from django import forms
24
from django.conf import settings
3-
from django.db.models import Max
45
from django.template.defaultfilters import filesizeformat
56

67
from ietf.doc.models import Document
78
from ietf.name.models import DocTypeName
89
from ietf.meeting.models import Meeting
910

10-
import os
11-
import re
11+
12+
1213
# ---------------------------------------------
1314
# Globals
1415
# ---------------------------------------------

ietf/secr/proceedings/models.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
1+
import os
2+
13
from django.conf import settings
24
from django.db import models
3-
from django.shortcuts import get_object_or_404
45

56
from ietf.meeting.models import Meeting
67
from ietf.secr.utils.meeting import get_upload_root
78

8-
import datetime
9-
import os
109

1110
class InterimManager(models.Manager):
1211
'''A custom manager to limit objects to type=interim'''
@@ -68,6 +67,6 @@ class Registration(models.Model):
6867
country = models.CharField(max_length=2)
6968

7069
def __unicode__(self):
71-
return "%s %s" % (fname, lname)
70+
return "%s %s" % (self.fname, self.lname)
7271
class Meta:
7372
db_table = 'registrations'

ietf/secr/proceedings/proc_utils.py

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,26 +3,27 @@
33
44
This module contains all the functions for generating static proceedings pages
55
'''
6+
from urllib2 import urlopen
7+
import datetime
8+
import glob
9+
import os
10+
import shutil
11+
612
from django.conf import settings
713
from django.shortcuts import render_to_response
14+
15+
from ietf.doc.models import Document, RelatedDocument, DocEvent
816
from ietf.group.models import Group, Role
917
from ietf.group.utils import get_charter_text
10-
from ietf.meeting.helpers import get_schedule, meeting_updated
11-
from ietf.meeting.models import Session, TimeSlot, Meeting, ScheduledSession
12-
from ietf.doc.models import Document, RelatedDocument, DocEvent
13-
from itertools import chain
18+
from ietf.meeting.helpers import get_schedule
19+
from ietf.meeting.models import Session, Meeting, ScheduledSession
20+
from ietf.secr.proceedings.models import InterimMeeting # proxy model
1421
from ietf.secr.proceedings.models import Registration
1522
from ietf.secr.utils.document import get_rfc_num
1623
from ietf.secr.utils.group import groups_by_session
1724
from ietf.secr.utils.meeting import get_upload_root, get_proceedings_path, get_material, get_session
18-
from models import InterimMeeting # proxy model
1925

20-
from urllib2 import urlopen
21-
import datetime
22-
import glob
23-
import os
24-
import shutil
25-
import stat
26+
2627

2728
# -------------------------------------------------
2829
# Helper Functions
@@ -80,9 +81,9 @@ def get_progress_stats(sdate,edate):
8081
monday = Meeting.get_ietf_monday()
8182
cutoff = monday + datetime.timedelta(days=3)
8283
ff1_date = cutoff - datetime.timedelta(days=28)
83-
ff2_date = cutoff - datetime.timedelta(days=21)
84-
ff3_date = cutoff - datetime.timedelta(days=14)
85-
ff4_date = cutoff - datetime.timedelta(days=7)
84+
#ff2_date = cutoff - datetime.timedelta(days=21)
85+
#ff3_date = cutoff - datetime.timedelta(days=14)
86+
#ff4_date = cutoff - datetime.timedelta(days=7)
8687

8788
ff_docs = Document.objects.filter(type='draft').filter(docevent__type='new_revision',
8889
docevent__newrevisiondocevent__rev='00',

ietf/secr/proceedings/report_progress_report.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from ietf.secr.proceedings.proc_utils import gen_progress
88
from ietf.meeting.models import Meeting
99
import datetime
10-
import sys
10+
1111

1212
now = datetime.date.today()
1313
meeting = Meeting.objects.filter(date__lte=now).order_by('-date')[0]

ietf/secr/proceedings/templatetags/ams_filters.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
from django import template
2+
23
from ietf.person.models import Person
3-
import datetime
4+
45

56
register = template.Library()
67

@@ -63,7 +64,7 @@ def smart_login(user):
6364
Expects a Person object. If person is a Secretariat returns "on behalf of the"
6465
'''
6566
if not isinstance (user, Person):
66-
return value
67+
return user
6768
if user.role_set.filter(name='secr',group__acronym='secretariat'):
6869
return '%s, on behalf of the' % user
6970
else:

ietf/secr/proceedings/tests.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1+
import debug # pyflakes:ignore
2+
13
from django.core.urlresolvers import reverse
2-
from ietf.utils import TestCase
34

5+
from ietf.utils import TestCase
46
from ietf.meeting.models import Meeting
57
from ietf.utils.test_data import make_test_data
68

7-
from pyquery import PyQuery
8-
import debug # pyflakes:ignore
99

1010
SECR_USER='secretary'
1111

ietf/secr/proceedings/urls.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from django.conf.urls import *
1+
from django.conf.urls import patterns, url
22

33
urlpatterns = patterns('ietf.secr.proceedings.views',
44
url(r'^$', 'main', name='proceedings'),

ietf/secr/proceedings/views.py

Lines changed: 17 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,44 +1,37 @@
1+
import datetime
2+
import glob
3+
import itertools
4+
import os
5+
import shutil
6+
17
from django.conf import settings
28
from django.contrib import messages
3-
from django.core.exceptions import ObjectDoesNotExist, MultipleObjectsReturned
9+
from django.core.exceptions import ObjectDoesNotExist
410
from django.core.urlresolvers import reverse
511
from django.db.models import Max
6-
from django.forms.formsets import formset_factory
7-
from django.forms.models import inlineformset_factory, modelformset_factory
8-
from django.http import HttpResponseRedirect, HttpResponse, HttpResponseForbidden
12+
from django.http import HttpResponseRedirect
913
from django.shortcuts import render_to_response, get_object_or_404
1014
from django.template import RequestContext
11-
from django.template import Context
12-
from django.template.loader import get_template
1315
from django.utils.text import slugify
14-
from django.db.models import Max,Count,get_model
1516

1617
from ietf.secr.lib.template import jsonapi
17-
from ietf.secr.proceedings.proc_utils import *
1818
from ietf.secr.sreq.forms import GroupSelectForm
1919
from ietf.secr.utils.decorators import check_permissions, sec_only
20-
from ietf.secr.utils.document import get_rfc_num, get_full_path
20+
from ietf.secr.utils.document import get_full_path
2121
from ietf.secr.utils.group import get_my_groups, groups_by_session
22-
from ietf.secr.utils.meeting import get_upload_root, get_proceedings_path, get_material, get_timeslot
23-
24-
from ietf.doc.models import Document, DocAlias, DocEvent, State, NewRevisionDocEvent, RelatedDocument
22+
from ietf.secr.utils.meeting import get_upload_root, get_material, get_timeslot
23+
from ietf.doc.models import Document, DocAlias, DocEvent, State, NewRevisionDocEvent
2524
from ietf.group.models import Group
26-
from ietf.group.utils import get_charter_text
2725
from ietf.ietfauth.utils import has_role
2826
from ietf.meeting.models import Meeting, Session, TimeSlot, ScheduledSession
29-
from ietf.name.models import MeetingTypeName, SessionStatusName
30-
from ietf.person.models import Person
27+
from ietf.secr.proceedings.forms import EditSlideForm, InterimMeetingForm, ReplaceSlideForm, UnifiedUploadForm
28+
from ietf.secr.proceedings.proc_utils import ( gen_acknowledgement, gen_agenda, gen_areas, gen_attendees,
29+
gen_group_pages, gen_index, gen_irtf, gen_overview, gen_plenaries, gen_progress, gen_research,
30+
gen_training, create_proceedings, create_interim_directory )
31+
32+
from ietf.secr.proceedings.models import InterimMeeting # proxy model
3133

32-
from forms import *
33-
from models import InterimMeeting # proxy model
3434

35-
import datetime
36-
import glob
37-
import itertools
38-
import os
39-
import re
40-
import shutil
41-
import zipfile
4235

4336
# -------------------------------------------------
4437
# Helper Functions
@@ -273,8 +266,6 @@ def ajax_order_slide(request):
273266

274267
# get all the slides for this session
275268
session = slide.session_set.all()[0]
276-
meeting = session.meeting
277-
group = session.group
278269
qs = session.materials.exclude(states__slug='deleted').filter(type='slides').order_by('order')
279270

280271
# move slide and reorder list
@@ -741,8 +732,6 @@ def select_interim(request):
741732
groups = get_my_groups(request.user)
742733
choices = build_choices(groups)
743734
group_form = GroupSelectForm(choices=choices)
744-
irtf_form = None
745-
training_form = None
746735

747736
return render_to_response('proceedings/interim_select.html', {
748737
'group_form': group_form},

0 commit comments

Comments
 (0)