Skip to content

Commit f733c1a

Browse files
committed
Merged [2676] from kivinen@iki.fi:
Added new setting to the /cookies page which enables always showing full document text instead of showing beginning of the document. This fixes issue ietf-tools#551. - Legacy-Id: 2680 Note: SVN reference [2676] has been migrated to Git commit f7a33ef
1 parent b0576a0 commit f733c1a

4 files changed

Lines changed: 41 additions & 4 deletions

File tree

ietf/cookies/urls.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,6 @@
99
(r'^new_enough/', views.new_enough),
1010
(r'^expires_soon/(?P<days>.*)$', views.expires_soon),
1111
(r'^expires_soon/', views.expires_soon),
12+
(r'^full_draft/(?P<enabled>.*)$', views.full_draft),
13+
(r'^full_draft/', views.full_draft),
1214
)

ietf/cookies/views.py

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
from django.shortcuts import render_to_response as render, get_object_or_404
55
from django.template import RequestContext
66

7-
def settings(request, new_enough = -1, expires_soon = -1):
7+
def settings(request, new_enough = -1, expires_soon = -1, full_draft = ""):
88
if new_enough < 0:
99
if "new_enough" in request.COOKIES:
1010
new_enough = int(request.COOKIES["new_enough"])
@@ -15,10 +15,16 @@ def settings(request, new_enough = -1, expires_soon = -1):
1515
expires_soon = int(request.COOKIES["expires_soon"])
1616
else:
1717
expires_soon = 14
18+
if full_draft == "":
19+
if "full_draft" in request.COOKIES:
20+
full_draft = request.COOKIES["full_draft"]
21+
else:
22+
full_draft = "off"
1823
return render("cookies/settings.html",
1924
{
2025
"new_enough" : new_enough,
21-
"expires_soon" : expires_soon
26+
"expires_soon" : expires_soon,
27+
"full_draft" : full_draft
2228
}, context_instance=RequestContext(request))
2329

2430
def new_enough(request, days="14"):
@@ -42,3 +48,10 @@ def expires_soon(request, days="14"):
4248
response = settings(request, -1, days)
4349
response.set_cookie("expires_soon", days)
4450
return response
51+
52+
def full_draft(request, enabled="off"):
53+
if enabled != "on" and enabled != "off":
54+
enabled = "off"
55+
response = settings(request, -1, -1, enabled)
56+
response.set_cookie("full_draft", enabled)
57+
return response

ietf/idrfc/views_doc.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,13 @@ def _get_html(key, filename):
7474
(c1,c2) = markup_txt.markup(raw_content)
7575
return (c1,c2)
7676

77+
def include_text(request):
78+
include_text = request.GET.get( 'include_text' )
79+
if "full_draft" in request.COOKIES:
80+
if request.COOKIES["full_draft"] == "on":
81+
include_text = 1
82+
return include_text
83+
7784
def document_main_rfc(request, rfc_number, tab):
7885
rfci = get_object_or_404(RfcIndex, rfc_number=rfc_number)
7986
doc = RfcWrapper(rfci)
@@ -99,7 +106,7 @@ def document_main_rfc(request, rfc_number, tab):
99106
return render_to_response(template + ".html",
100107
{'content1':content1, 'content2':content2,
101108
'doc':doc, 'info':info, 'tab':tab,
102-
'include_text':request.GET.get( 'include_text' ),
109+
'include_text':include_text(request),
103110
'history':history},
104111
context_instance=RequestContext(request));
105112

@@ -150,7 +157,7 @@ def document_main(request, name, tab):
150157
return render_to_response(template + ".html",
151158
{'content1':content1, 'content2':content2,
152159
'doc':doc, 'info':info, 'tab':tab,
153-
'include_text':request.GET.get( 'include_text' ),
160+
'include_text':include_text(request),
154161
'versions':versions, 'history':history},
155162
context_instance=RequestContext(request));
156163

ietf/templates/cookies/settings.html

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,21 @@ <h2 class="ietf-divider">How many days is considered soon</h2>
4848
<td>{% if expires_soon|equal:"60" %}<span class="ietf-highlight-y"><a href="/cookies/expires_soon/60">60 days</a></span>{%else%}<a href="/cookies/expires_soon/60">60 days</a>{% endif %}</td>
4949
<td>{% if expires_soon|equal:"90" %}<span class="ietf-highlight-y"><a href="/cookies/expires_soon/90">90 days</a></span>{%else%}<a href="/cookies/expires_soon/90">90 days</a>{% endif %}</td>
5050
</tr>
51+
52+
<tr class="setting-header">
53+
<td colspan="6">
54+
<h2 class="ietf-divider">Show full document text in document page</h2>
55+
</td>
56+
<tr>
57+
<tr class="setting-description">
58+
<td colspan="6">
59+
<p>Show the full draft immediately on the document page instead of only showing beginning of it. This defaults to off.</p>
60+
</td>
61+
</tr>
62+
<tr class="settings-values">
63+
<td>{% if full_draft|equal:"off" %}<span class="ietf-highlight-y"><a href="/cookies/full_draft/off">off</a></span>{%else%}<a href="/cookies/full_draft/off">off</a>{% endif %}</td></td>
64+
<td>{% if full_draft|equal:"on" %}<span class="ietf-highlight-y"><a href="/cookies/full_draft/on">on</a></span>{%else%}<a href="/cookies/full_draft/on">on</a>{% endif %}</td></td>
65+
</tr>
5166
</table>
5267
{% endblock %}
5368

0 commit comments

Comments
 (0)