Skip to content

Commit f54d6cd

Browse files
committed
Merged in [16092] from rcross@amsl.com:
Remove ability to cancel a break session. Fixes ietf-tools#2703. - Legacy-Id: 16105 Note: SVN reference [16092] has been migrated to Git commit b5850d5
2 parents 6ab5e04 + b5850d5 commit f54d6cd

6 files changed

Lines changed: 20 additions & 11 deletions

File tree

ietf/dbtemplate/urls.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44
from ietf.utils.urls import url
55

66
urlpatterns = [
7-
url(r'^(?P<acronym>[-a-z0-9]+)/$', views.template_list),
8-
url(r'^(?P<acronym>[-a-z0-9]+)/(?P<template_id>[\d]+)/$', views.template_edit),
7+
url(r'^(?P<acronym>[-a-z0-9]+)/$', views.group_template_list),
8+
url(r'^(?P<acronym>[-a-z0-9]+)/(?P<template_id>[\d]+)/$', views.group_template_edit),
99
]

ietf/dbtemplate/views.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
from ietf.ietfauth.utils import has_role
1010

1111

12-
def template_list(request, acronym):
12+
def group_template_list(request, acronym):
1313
group = get_object_or_404(Group, acronym=acronym)
1414
chairs = group.role_set.filter(name__slug='chair')
1515
if not has_role(request.user, "Secretariat") and not (request.user.id and chairs.filter(person__user=request.user).count()):
@@ -22,7 +22,7 @@ def template_list(request, acronym):
2222
})
2323

2424

25-
def template_edit(request, acronym, template_id, base_template='dbtemplate/template_edit.html', formclass=DBTemplateForm, extra_context=None):
25+
def group_template_edit(request, acronym, template_id, base_template='dbtemplate/template_edit.html', formclass=DBTemplateForm, extra_context=None):
2626
group = get_object_or_404(Group, acronym=acronym)
2727
chairs = group.role_set.filter(name__slug='chair')
2828
extra_context = extra_context or {}
@@ -46,7 +46,7 @@ def template_edit(request, acronym, template_id, base_template='dbtemplate/templ
4646
context.update(extra_context)
4747
return render(request, base_template, context)
4848

49-
def template_show(request, acronym, template_id, base_template='dbtemplate/template_edit.html', extra_context=None):
49+
def group_template_show(request, acronym, template_id, base_template='dbtemplate/template_edit.html', extra_context=None):
5050
group = get_object_or_404(Group, acronym=acronym)
5151
chairs = group.role_set.filter(name__slug='chair')
5252
extra_context = extra_context or {}

ietf/nomcom/views.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616

1717
from ietf.dbtemplate.models import DBTemplate
18-
from ietf.dbtemplate.views import template_edit, template_show
18+
from ietf.dbtemplate.views import group_template_edit, group_template_show
1919
from ietf.name.models import NomineePositionStateName, FeedbackTypeName
2020
from ietf.group.models import Group, GroupEvent
2121
from ietf.message.models import Message
@@ -1027,15 +1027,15 @@ def edit_template(request, year, template_id):
10271027
return_url = request.META.get('HTTP_REFERER', None)
10281028

10291029
if nomcom.group.state_id=='conclude':
1030-
return template_show(request, nomcom.group.acronym, template_id,
1030+
return group_template_show(request, nomcom.group.acronym, template_id,
10311031
base_template='nomcom/show_template.html',
10321032
extra_context={'year': year,
10331033
'return_url': return_url,
10341034
'nomcom': nomcom,
10351035
'is_chair_task' : True,
10361036
})
10371037
else:
1038-
return template_edit(request, nomcom.group.acronym, template_id,
1038+
return group_template_edit(request, nomcom.group.acronym, template_id,
10391039
base_template='nomcom/edit_template.html',
10401040
formclass=NomComTemplateForm,
10411041
extra_context={'year': year,

ietf/secr/meetings/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -534,7 +534,7 @@ def non_session_edit(request, meeting_id, schedule_name, slot_id):
534534

535535
if request.method == 'POST':
536536
button_text = request.POST.get('submit', '')
537-
if button_text == 'Cancel':
537+
if button_text == 'Back':
538538
return redirect('ietf.secr.meetings.views.non_session', meeting_id=meeting_id, schedule_name=schedule_name)
539539

540540
form = NonSessionForm(request.POST,meeting=meeting,session=session)

ietf/secr/templates/meetings/non_session.html

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,11 @@ <h2>TimeSlots</h2>
3434
<td>{{ assignment.timeslot.show_location }}</td>
3535
<td>{{ assignment.timeslot.type }}</td>
3636
<td><a href="{% url "ietf.secr.meetings.views.non_session_edit" meeting_id=meeting.number schedule_name=schedule.name slot_id=assignment.timeslot.id %}">Edit</a></td>
37-
<td><a href="{% url "ietf.secr.meetings.views.non_session_cancel" meeting_id=meeting.number schedule_name=schedule.name slot_id=assignment.timeslot.id %}">Cancel</a></td>
37+
<td>
38+
{% if not assignment.session.type.slug == "break" %}
39+
<a href="{% url "ietf.secr.meetings.views.non_session_cancel" meeting_id=meeting.number schedule_name=schedule.name slot_id=assignment.timeslot.id %}">Cancel</a>
40+
{% endif %}
41+
</td>
3842
<td><a href="{% url "ietf.secr.meetings.views.non_session_delete" meeting_id=meeting.number schedule_name=schedule.name slot_id=assignment.timeslot.id %}">Delete</a></td>
3943
</tr>
4044
{% endfor %}

ietf/secr/templates/meetings/non_session_edit.html

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,12 @@ <h2>Meeting - {{ meeting }}</h2>
1010
{{ form.as_table }}
1111
</table>
1212

13-
{% include "includes/buttons_save_cancel.html" %}
13+
<div class="button-group">
14+
<ul>
15+
<li><button type="submit" name="submit" value="Save">Save</button></li>
16+
<li><button type="submit" name="submit" value="Back">Back</button></li>
17+
</ul>
18+
</div> <!-- button-group -->
1419

1520
</form>
1621
</div> <!-- module -->

0 commit comments

Comments
 (0)