Skip to content

Commit f4ce5e0

Browse files
committed
Fix django 1.7 incompatibilities: Remove get_fieldsets() methods which don't work any more because of Django's move from using its own SortedDict to python's OrderedDict (which always is available in python 2.7 and later). The get_fieldsets() method on Form wasn't available in early versions of django, but since it's provided now, we don't need own code for this method.
- Legacy-Id: 8830
1 parent 731744c commit f4ce5e0

2 files changed

Lines changed: 0 additions & 29 deletions

File tree

ietf/liaisons/forms.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -118,20 +118,6 @@ def set_organization_field(self):
118118
def as_div(self):
119119
return render_to_string('liaisons/liaisonform.html', {'form': self})
120120

121-
def get_fieldsets(self):
122-
if not self.fieldsets:
123-
yield dict(name=None, fields=self)
124-
else:
125-
for fieldset, fields in self.fieldsets:
126-
fieldset_dict = dict(name=fieldset, fields=[])
127-
for field_name in fields:
128-
if field_name in self.fields.keyOrder:
129-
fieldset_dict['fields'].append(self[field_name])
130-
if not fieldset_dict['fields']:
131-
# if there is no fields in this fieldset, we continue to next fieldset
132-
continue
133-
yield fieldset_dict
134-
135121
def full_clean(self):
136122
self.set_required_fields()
137123
super(LiaisonForm, self).full_clean()

ietf/nomcom/forms.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -89,21 +89,6 @@ def __unicode__(self):
8989
def as_div(self):
9090
return render_to_string('nomcom/nomcomform.html', {'form': self})
9191

92-
def get_fieldsets(self):
93-
if not self.fieldsets:
94-
yield dict(name=None, fields=self)
95-
else:
96-
for fieldset, fields in self.fieldsets:
97-
fieldset_dict = dict(name=fieldset, fields=[])
98-
for field_name in fields:
99-
if field_name in self.fields.keyOrder:
100-
fieldset_dict['fields'].append(self[field_name])
101-
if not fieldset_dict['fields']:
102-
# if there is no fields in this fieldset, we continue to next fieldset
103-
continue
104-
yield fieldset_dict
105-
106-
10792
class EditMembersForm(BaseNomcomForm, forms.Form):
10893

10994
members = MultiEmailField(label="Members email", required=False, widget=forms.Textarea)

0 commit comments

Comments
 (0)