Skip to content

Commit f3d31f0

Browse files
committed
Don't hide exceptions by returning a blank form when something goes wrong -- there's been temporary upload failures for some time, which have been difficult to trace and debug because the error condition has been hidden.
- Legacy-Id: 3514
1 parent 0787ef4 commit f3d31f0

1 file changed

Lines changed: 4 additions & 7 deletions

File tree

ietf/submit/views.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,10 @@
2121

2222
def submit_index(request):
2323
if request.method == 'POST':
24-
try:
25-
form = UploadForm(request=request, data=request.POST, files=request.FILES)
26-
if form.is_valid():
27-
submit = form.save()
28-
return HttpResponseRedirect(reverse(draft_status, None, kwargs={'submission_id': submit.submission_id, 'submission_hash': submit.get_hash()}))
29-
except IOError:
30-
form = UploadForm(request=request)
24+
form = UploadForm(request=request, data=request.POST, files=request.FILES)
25+
if form.is_valid():
26+
submit = form.save()
27+
return HttpResponseRedirect(reverse(draft_status, None, kwargs={'submission_id': submit.submission_id, 'submission_hash': submit.get_hash()}))
3128
else:
3229
form = UploadForm(request=request)
3330
return render_to_response('submit/submit_index.html',

0 commit comments

Comments
 (0)