Skip to content

Commit f2cb2aa

Browse files
committed
Merged in [17233] from rjsparks@nostrum.com:
Be clear about who changed a group's personnel in the resulting email message. Fixes ietf-tools#2868. - Legacy-Id: 17235 Note: SVN reference [17233] has been migrated to Git commit f0f5223
2 parents 82baf77 + f0f5223 commit f2cb2aa

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

ietf/group/tests_info.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -627,6 +627,7 @@ def test_edit_info(self):
627627
self.assertTrue('Personnel change' in outbox[0]['Subject'])
628628
for prefix in ['ad1','ad2','aread','marschairman','marsdelegate']:
629629
self.assertTrue(prefix+'@' in outbox[0]['To'])
630+
self.assertTrue(outbox[0].get_payload(decode=True).decode(str(outbox[0].get_charset())).startswith('Sec Retary'))
630631

631632

632633
def test_edit_field(self):

ietf/group/views.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1003,6 +1003,7 @@ def diff(attr, name):
10031003
changed_personnel.update(set(old)^set(new))
10041004

10051005
if personnel_change_text!="":
1006+
personnel_change_text = "%s has updated %s personnel:\n\n" % (request.user.person.plain_name(), group.acronym.upper() ) + personnel_change_text
10061007
email_personnel_change(request, group, personnel_change_text, changed_personnel)
10071008

10081009
# update urls

0 commit comments

Comments
 (0)