minor comments and one addition to test_save_agenda...

 - Legacy-Id: 7453

Author: rjsparks

ietf/meeting/tests_api.py

@@ -155,6 +155,7 @@ def test_delete_room(self):
         self.assertTrue(not meeting.room_set.filter(pk=room.pk))
         self.assertTrue(not TimeSlot.objects.filter(pk__in=timeslots_before))
 
+    # This really belongs in group tests
     def test_group_json(self):
         meeting = make_meeting_test_data()
         group = Group.objects.get(acronym="mars")
@@ -165,6 +166,7 @@ def test_group_json(self):
         info = json.loads(r.content)
         self.assertEqual(info["name"], group.name)
 
+    # This really belongs in person tests
     def test_person_json(self):
         meeting = make_meeting_test_data()
         person = Person.objects.get(user__username="ad")

ietf/meeting/tests_views.py

@@ -163,9 +163,14 @@ def test_edit_agenda(self):
 
     def test_save_agenda_as_and_read_permissions(self):
         meeting = make_meeting_test_data()
-        url = urlreverse("ietf.meeting.views.edit_agenda", kwargs=dict(num=meeting.number))
+
+        # try to get non-existing agenda
+        url = urlreverse("ietf.meeting.views.edit_agenda", kwargs=dict(num=meeting.number, name="foo"))
+        r = self.client.get(url)
+        self.assertEqual(r.status_code, 404)
 
         # save as
+        url = urlreverse("ietf.meeting.views.edit_agenda", kwargs=dict(num=meeting.number))
         self.client.login(remote_user="ad")
         r = self.client.post(url, {
             'savename': "foo",