Skip to content

Commit ef28ba9

Browse files
committed
Use PersonHistory to grab old affiliation
- Legacy-Id: 3306
1 parent 94756e0 commit ef28ba9

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

ietf/meeting/proxy.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -501,16 +501,18 @@ class Meta:
501501

502502
class IESGHistoryProxy(Person):
503503
def from_object(self, base):
504-
for f in base._meta.fields:
504+
for f in self._meta.fields: # self here to enable us to copy a history object
505505
setattr(self, f.name, getattr(base, f.name))
506506
return self
507507

508508
#meeting = models.ForeignKey(Meeting, db_column='meeting_num')
509-
def from_role(self, role):
510-
self.from_object(role.email.person)
509+
def from_role(self, role, time):
510+
from ietf.utils.history import find_history_active_at
511+
personhistory = find_history_active_at(role.email.person, time)
512+
print personhistory
513+
self.from_object(personhistory or role.email.person)
511514
from redesign.group.proxy import Area
512515
self.area = Area().from_object(role.group)
513-
self.affiliation = "" #role.email.affiliation
514516
return self
515517
#area = models.ForeignKey(Area, db_column='area_acronym_id')
516518
#person = models.ForeignKey(PersonOrOrgInfo, db_column='person_or_org_tag')

ietf/meeting/views.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,10 +147,10 @@ def agenda_infoREDESIGN(num=None):
147147
history = find_history_active_at(g, meeting_time)
148148
if history:
149149
if history.state_id == "active":
150-
ads.extend(IESGHistory().from_role(x) for x in history.rolehistory_set.filter(name="ad"))
150+
ads.extend(IESGHistory().from_role(x, meeting_time) for x in history.rolehistory_set.filter(name="ad"))
151151
else:
152152
if g.state_id == "active":
153-
ads.extend(IESGHistory().from_role(x) for x in g.role_set.filter(name="ad"))
153+
ads.extend(IESGHistory().from_role(x, meeting_time) for x in g.role_set.filter(name="ad"))
154154

155155
from redesign.doc.models import Document
156156
plenary_agendas = Document.objects.filter(timeslot__meeting=meeting, timeslot__type="plenary", type="agenda").distinct()

0 commit comments

Comments
 (0)