Skip to content

Commit ed583bc

Browse files
committed
Used a more sophisticated algorithm for separation of person name parts in the photo_name() method. Added support for 'Dr' (without dot) as a titular prefix.
- Legacy-Id: 11275
1 parent fe50693 commit ed583bc

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

ietf/person/models.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,8 @@ def full_name_as_key(self):
9494

9595
def photo_name(self,thumb=False):
9696
hasher = Hashids(salt='Person photo name salt',min_length=5)
97-
return '%s-%s%s' % ( slugify(self.ascii), hasher.encode(self.id), '-th' if thumb else '' )
97+
_, first, _, last, _ = name_parts(self.ascii)
98+
return '%s-%s%s' % ( slugify("%s %s" % (first, last)), hasher.encode(self.id), '-th' if thumb else '' )
9899

99100
class Meta:
100101
abstract = True

ietf/person/name.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def name_parts(name):
1313
if len(parts) > 2 and parts[0] in ["M", "M.", "Sri", ] and "." not in parts[1]:
1414
prefix = parts[0];
1515
parts = parts[1:]
16-
if parts[0] in ["Mr", "Mr.", "Mrs", "Mrs.", "Ms", "Ms.", "Miss", "Dr.", "Doctor", "Prof", "Prof.", "Professor", "Sir", "Lady", "Dame", ]:
16+
if parts[0] in ["Mr", "Mr.", "Mrs", "Mrs.", "Ms", "Ms.", "Miss", "Dr", "Dr.", "Doctor", "Prof", "Prof.", "Professor", "Sir", "Lady", "Dame", ]:
1717
prefix = parts[0];
1818
parts = parts[1:]
1919
if len(parts) > 2:
@@ -52,4 +52,4 @@ def initials(name):
5252
name = " ".join(sys.argv[1:])
5353
print name_parts(name)
5454
print initials(name)
55-
55+

0 commit comments

Comments
 (0)