Skip to content

Commit ecac9c2

Browse files
author
Martin Qvist
committed
Final corrections and coord with Ole. Fixed agenda package, template cleanup, more tests and a couple of bugs.
- Legacy-Id: 3360
1 parent 2ed5c35 commit ecac9c2

24 files changed

Lines changed: 428 additions & 218 deletions

ietf/iesg/views.py

Lines changed: 22 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,19 @@ def get_doc_sectionREDESIGN(id):
208208
s = s + "1"
209209
return s
210210

211+
def get_wg_section(wg):
212+
if wg.state_id == "proposed":
213+
if wg.charter.charter_state_id == "intrev":
214+
s = '411'
215+
elif wg.charter.charter_state_id == "iesgrev":
216+
s = '412'
217+
elif wg.state_id == "active":
218+
if wg.charter.charter_state_id == "intrev":
219+
s = '421'
220+
elif wg.charter.charter_state_id == "iesgrev":
221+
s = '422'
222+
return s
223+
211224
if settings.USE_DB_REDESIGN_PROXY_CLASSES:
212225
get_doc_section = get_doc_sectionREDESIGN
213226

@@ -253,15 +266,17 @@ def agenda_docs(date, next_agenda):
253266
return res
254267

255268
def agenda_wg_actions(date):
256-
mapping = {12:'411', 13:'412',22:'421',23:'422'}
257-
matches = WGAction.objects.filter(agenda=1,telechat_date=date,category__in=mapping.keys()).order_by('category')
258-
res = {}
259-
for o in matches:
260-
section_key = "s"+mapping[o.category]
269+
from doc.models import TelechatDocEvent
270+
from group.models import Group
271+
272+
matches = Group.objects.filter(charter__docevent__telechatdocevent__telechat_date=date)
273+
274+
res = dict(("s%s%s%s" % (i, j, k), []) for i in range(2, 5) for j in range (1, 4) for k in range(1, 4))
275+
for wg in list(matches):
276+
section_key = "s"+get_wg_section(wg)
261277
if section_key not in res:
262278
res[section_key] = []
263-
area = AreaGroup.objects.get(group=o.group_acronym)
264-
res[section_key].append({'obj':o, 'area':str(area.area)})
279+
res[section_key].append({'obj':wg})
265280
return res
266281

267282
def agenda_management_issues(date):

ietf/templates/iesg/agenda_wg.html

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -43,20 +43,14 @@ <h3>{{ title2 }}</h3>
4343
{% endif %}
4444

4545
<tr>
46-
<td>{{wg.area|upper}}</td>
47-
<td>{{ wg.obj.status_date|date:"M d"}}</td>
46+
<td>{{wg.obj.parent.name|upper}}</td>
47+
<td>{{ wg.obj.time|date:"M d"}}</td>
4848
<td>
49-
<a href="http://www.ietf.org/iesg/evaluation/{{wg.obj.group_acronym}}-charter.txt">
50-
{{ wg.obj.group_acronym.name|escape }} ({{wg.obj.group_acronym}})
49+
<a href="http://www.ietf.org/iesg/evaluation/charter-ietf-{{wg.obj.acronym}}-{{wg.obj.charter.rev}}.txt">
50+
{{ wg.obj.name|escape }} ({{wg.obj.acronym}})
5151
</a>
5252
</td>
5353
</tr>
54-
{% if wg.obj.token_name %}
55-
<tr><td></td><td>Token:</td><td>{{ wg.obj.token_name|escape }}</td></tr>
56-
{% endif %}
57-
{% if wg.obj.note %}
58-
<tr><td></td><td></td><td>Note: {{wg.obj.note|escape}}</td></tr>
59-
{% endif %}
6054

6155
{% if forloop.last %}
6256
</table>

ietf/templates/iesg/agenda_wg.txt

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
3535
{{ title2 }}
3636
{% endif %}{{ title3 }}
3737
{% for wg in section_wgs %}
38-
o {{ wg.obj.group_acronym.name }} ({{wg.obj.group_acronym}})
39-
{% if wg.obj.token_name %} Token: {{ wg.obj.token_name }}
40-
{% endif %}
41-
{% if wg.obj.note %} {% filter wordwrap:"68"|indent|indent %}Note: {{wg.obj.note|striptags}}{% endfilter %}
42-
{% endif %}
38+
o {{ wg.obj.name }} ({{wg.obj.acronym}})
4339
{% empty %}
4440
NONE
4541
{% endfor %}

ietf/templates/iesg/moderator_wg.html

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,7 @@ <h3>{{ title1 }}<br>
3636
{{ title2 }}<br>
3737
{{ title3 }} ({{ forloop.counter }} of {{ section_wgs|length }})</h3>
3838

39-
<p><b>{{ wg.obj.group_acronym.name }} ({{wg.obj.group_acronym}})<br>
40-
{% if wg.obj.token_name %}
41-
Token: {{ wg.obj.token_name }}
42-
{% endif %}</b></p>
43-
44-
{% if wg.obj.note %}
45-
<p>Note: {{wg.obj.note|striptags}}</p>
46-
{% endif %}
39+
<p><b>{{ wg.obj.name }} ({{wg.obj.acronym}})<br>
4740

4841
{% if title3|startswith:"4.1.1" %}
4942
<p>Does anyone have an objection to the charter being sent for
Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{% extends "base.html" %}
22

3-
{% block title %}WG {{ announcement }} announcement writeup for {{ doc.group.acronym }}{% endblock %}
3+
{% block title %}WG {{ announcement }} announcement writeup for {{ charter.chartered_group.acronym }}{% endblock %}
44

55
{% block morecss %}
66
form #id_announcement_text {
@@ -10,7 +10,7 @@
1010
{% endblock %}
1111

1212
{% block content %}
13-
<h1>WG {{ announcement }} announcement writeup for {{ doc.group.acronym }}</h1>
13+
<h1>WG {{ announcement }} announcement writeup for {{ charter.chartered_group.acronym }}</h1>
1414

1515
<form action="" method="POST">
1616

@@ -22,12 +22,4 @@ <h1>WG {{ announcement }} announcement writeup for {{ doc.group.acronym }}</h1>
2222
</div>
2323
</form>
2424

25-
{% load ietf_filters %}
26-
{% if user|in_group:"Secretariat" %}
27-
<p>
28-
{% if can_announce %}
29-
<a href="{% url doc_approve_ballot name=doc.name %}">Approve ballot</a>
30-
{% endif %}
31-
</p>
32-
{% endif %}
3325
{% endblock%}

ietf/templates/wgrecord/ballot_comment_mail.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{% autoescape off %}{{ ad }} has entered the following ballot position for
2-
{{ doc.filename }}-{{ doc.revision_display }}: {{ pos.name }}
2+
{{ charter.name }}-{{ charter.rev }}: {{ pos.name }}
33

44
When responding, please keep the subject line intact and reply to all
55
email addresses included in the To and CC lines. (Feel free to cut this

ietf/templates/wgrecord/ballot_issued.html

Lines changed: 0 additions & 13 deletions
This file was deleted.

ietf/templates/wgrecord/ballot_writeupnotes.html

Lines changed: 0 additions & 36 deletions
This file was deleted.

ietf/templates/wgrecord/edit_position.html

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@
33
{% block title %}Change position for {{ ad.name }} on {{ wg.acronym }}{% endblock %}
44

55
{% block morecss %}
6-
div.ballot-deferred {
7-
margin-top: 8px;
8-
margin-bottom: 8px;
9-
}
106
form.position-form .position ul {
117
padding: 0;
128
margin: 0;

ietf/templates/wgrecord/record_ballot.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ <h2 style="margin-top:12px;">Comments</h2>
4040

4141
{% for pos in info.positions %}
4242
{% if pos.comment or pos.block_comment %}
43-
<h2 class="ballot_ad"><a name="{{pos.ad|slugify}}">{% if pos.is_old_ad %}[{%endif%}{{pos.ad|escape}}{% if pos.is_old_ad %}]{%endif%}</a></h2>
43+
<h2 class="ballot_ad"><a name="{{pos.ad|slugify}}">{{pos.ad|escape}}</a></h2>
4444

4545
{% if pos.block_comment %}
4646
<p><b>Blocking ({{pos.block_comment_time}})</b> <img src="/images/comment.png" width="14" height="12" alt=""/></p>

0 commit comments

Comments
 (0)