Skip to content

Commit ebc37de

Browse files
committed
Link to review request even if it's completed, if there's no review
document associated - that shouldn't really happen, but the importer doesn't import reviews yet and we don't have content for all the old reviews. - Legacy-Id: 11509
1 parent e2e6652 commit ebc37de

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

ietf/templates/doc/document_draft.html

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,9 +201,12 @@
201201
{% for r in review_requests %}
202202
<div>
203203
{% if r.state_id == "completed" or r.state_id == "part-completed" %}
204-
<a href="{% url "doc_view" r.review.name %}">{{ r.team.acronym|upper }} {{ r.type.name }} Review{% if r.reviewed_rev and r.reviewed_rev != doc.rev %} (of -{{ r.reviewed_rev }}){% endif %}: {{ r.result.name }} {% if r.state_id == "part-completed" %}(partially completed){% endif %} - reviewer: {{ r.reviewer.person }}</a>
204+
<a href="{% if r.review %}{% url "doc_view" r.review.name %}{% else %}{% url "ietf.doc.views_review.review_request" r.doc_id r.pk %}{% endif %}">
205+
{{ r.team.acronym|upper }} {{ r.type.name }} Review{% if r.reviewed_rev and r.reviewed_rev != doc.rev %} (of -{{ r.reviewed_rev }}){% endif %}:
206+
{{ r.result.name }} {% if r.state_id == "part-completed" %}(partially completed){% endif %}
207+
- reviewer: {{ r.reviewer.person }}</a>
205208
{% else %}
206-
<a href="{% url "ietf.doc.views_review.review_request" doc.name r.pk %}">{{ r.team.acronym|upper }} {{ r.type.name }} Review{% if r.reviewer %} (reviewer: {{ r.reviewer.person }}){% endif %}</a>
209+
<a href="{% url "ietf.doc.views_review.review_request" r.doc_id r.pk %}">{{ r.team.acronym|upper }} {{ r.type.name }} Review{% if r.reviewer %} (reviewer: {{ r.reviewer.person }}){% endif %}</a>
207210
{% endif %}
208211
</div>
209212
{% endfor %}

0 commit comments

Comments
 (0)